DefaultElementLibrary was leaking its default builder

Fix the leak by managing the object life cycle with
an unique_ptr.

Signed-off-by: Kevin Rocard <kevin.rocard@intel.com>

Author: krocard

parameter/DefaultElementLibrary.h

@@ -34,6 +34,8 @@
 
 #include <map>
 #include <string>
+#include <memory>
+#include <utility>
 
 /** Factory that creates an element given an xml element. If no matching builder is found, it uses
   * the default builder.
@@ -46,17 +48,16 @@ class CDefaultElementLibrary: public CElementLibrary
 {
 public:
 
-    CDefaultElementLibrary() : _defaultBuilder(NULL) {}
     virtual ~CDefaultElementLibrary() {}
 
     /** Set the default builder used in fallback mechanism.
       * @see createElement() for more detail on this mechanism.
       *
       * @param[in] defaultBuilder if NULL default builder mechanism, else provided builder is used.
       */
-    void setDefaultBuilder(CDefaultElementBuilder* defaultBuilder)
+    void setDefaultBuilder(std::unique_ptr<CDefaultElementBuilder> defaultBuilder)
     {
-        _defaultBuilder = defaultBuilder;
+        _defaultBuilder = std::move(defaultBuilder);
     }
 
 
@@ -73,7 +74,7 @@ class CDefaultElementLibrary: public CElementLibrary
     CElement* createElement(const CXmlElement& xmlElement) const;
 
 private:
-    CDefaultElementBuilder* _defaultBuilder;
+    std::unique_ptr<CDefaultElementBuilder> _defaultBuilder;
 };
 
 template<class CDefaultElementBuilder>

parameter/SystemClass.cpp

@@ -38,6 +38,7 @@
 #include <assert.h>
 #include "PluginLocation.h"
 #include "Utility.h"
+#include "Memory.hpp"
 
 #define base CConfigurableElement
 
@@ -109,7 +110,7 @@ bool CSystemClass::loadSubsystems(string& strError,
     _pSubsystemLibrary->addElementBuilder("Virtual", new VirtualSubsystemBuilder(_logger));
     // Set virtual subsytem as builder fallback if required
     if (bVirtualSubsystemFallback) {
-        _pSubsystemLibrary->setDefaultBuilder(new VirtualSubsystemBuilder(_logger));
+        _pSubsystemLibrary->setDefaultBuilder(make_unique<VirtualSubsystemBuilder>(_logger));
     }
 
     // Add subsystem defined in shared libraries