Avoid ParameterManager inheritance to Element god class.

ParameterManager does not have to be a part of the Element tree.
Indeed, it is not represented in any xml file.
This patch avoids this inheritance and removes some "tricks" which
was used to forget the ParameterMgr root element.

Signed-off-by: Jules Clero <julesx.clero@intel.com>

Author: clero

parameter/ConfigurableElement.cpp

@@ -162,7 +162,7 @@ void CConfigurableElement::getListOfElementsWithMapping(
 {
     // Check parent
     const CElement* pParent = getParent();
-    if (isOfConfigurableElementType(pParent)) {
+    if (pParent != NULL) {
 
         const CConfigurableElement* pConfigurableElement =
                 static_cast<const CConfigurableElement*>(pParent);
@@ -242,7 +242,7 @@ ISyncer* CConfigurableElement::getSyncer() const
     // Check parent
     const CElement* pParent = getParent();
 
-    if (isOfConfigurableElementType(pParent)) {
+    if (pParent != NULL) {
 
         return static_cast<const CConfigurableElement*>(pParent)->getSyncer();
     }
@@ -311,7 +311,7 @@ void CConfigurableElement::getBelongingDomains(std::list<const CConfigurableDoma
     // Check parent
     const CElement* pParent = getParent();
 
-    if (isOfConfigurableElementType(pParent)) {
+    if (pParent != NULL) {
 
         static_cast<const CConfigurableElement*>(pParent)->getBelongingDomains(configurableDomainList);
     }
@@ -466,7 +466,7 @@ bool CConfigurableElement::belongsToDomainAscending(const CConfigurableDomain* p
     // Check parent
     const CElement* pParent = getParent();
 
-    if (isOfConfigurableElementType(pParent)) {
+    if (pParent != NULL) {
 
         return static_cast<const CConfigurableElement*>(pParent)->belongsTo(pConfigurableDomain);
     }
@@ -479,7 +479,7 @@ const CSubsystem* CConfigurableElement::getBelongingSubsystem() const
     const CElement* pParent = getParent();
 
     // Stop at system class
-    if (!pParent->getParent()) {
+    if (pParent == NULL) {
 
         return NULL;
     }
@@ -492,13 +492,3 @@ bool CConfigurableElement::isParameter() const
 {
     return false;
 }
-
-
-// Check parent is still of current type (by structure knowledge)
-bool CConfigurableElement::isOfConfigurableElementType(const CElement* pParent) const
-{
-    assert(pParent);
-
-    // Up to system class
-    return !!pParent->getParent();
-}

parameter/ConfigurableElement.h

@@ -141,9 +141,6 @@ class CConfigurableElement : public CElement
     void getBelongingDomains(std::list<const CConfigurableDomain*>& configurableDomainList) const;
     void listDomains(const std::list<const CConfigurableDomain*>& configurableDomainList, std::string& strResult, bool bVertical) const;
 
-    // Check parent is still of current type (by structure knowledge)
-    bool isOfConfigurableElementType(const CElement* pParent) const;
-
     // Offset in main blackboard
     uint32_t _uiOffset;
 

parameter/Element.cpp

@@ -531,8 +531,7 @@ const CElement* CElement::findChildOfKind(const string& strKind) const
 
 string CElement::getPath() const
 {
-    // Take out root element from the path
-    if (_pParent && _pParent->_pParent) {
+    if (_pParent != NULL) {
 
         return _pParent->getPath() + "/" + getPathName();
     }