Fixes to support sklearn 1.1 #980
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
/intelci: run |
1 similar comment
Contributor
Author
|
/intelci: run |
added 12 commits
February 28, 2022 14:47
Pahandrovich
force-pushed
the
sklearn-master-fixes
branch
from
dd6a19d to
5132d51
Compare
Contributor
Author
|
/intelci: run |
Alexsandruss
approved these changes
Feb 28, 2022
Contributor
Alexsandruss
left a comment
Alexsandruss
left a comment
There was a problem hiding this comment.
Minor: "complex method" warnings and notices should be disabled or fixed in future.
added 2 commits
February 28, 2022 18:16
Contributor
Author
|
/intelci: run |
KalyanovD
suggested changes
Mar 1, 2022
agorshk
reviewed
Mar 1, 2022
KalyanovD
approved these changes
Mar 1, 2022
KalyanovD
reviewed
Mar 1, 2022
| else: | ||
| def func(x, *args): | ||
| return _multinomial_loss_grad(x, *args)[0:2] | ||
| if sklearn_check_version('1.1'): |
Contributor
There was a problem hiding this comment.
Suggested change
| if sklearn_check_version('1.1'): | |
| if sklearn_check_version('1.1') and loss is not None: |
Contributor
There was a problem hiding this comment.
but maybe loss=None at line 431 was redundant...
Contributor
Author
There was a problem hiding this comment.
I think explicitly specifying loss = None is safer
Contributor
Author
|
/intelci: run |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.