Enable compilation with WError #499
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| auto shape_scale = cute::make_shape(dq_mn_size, scale_k, L); | ||
| auto shape_zero = [&]() { | ||
| if constexpr (is_tuple_v<std::remove_reference_t<decltype(cute::get<1>(stride_Z))>>) { | ||
| auto shape_zero = [&, stride_Z_ref = std::ref(stride_Z)]() { |
There was a problem hiding this comment.
I prefer a solution without std::ref. Possible option: move the is_tuple_v out of the lambda and assign to variable.
|
Closing this as will continue with another PR with #502 with all the fixes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to enable warnings as error on cutlass build.
All the current compilation errors are fixed to enable
this feature.