Fix compilation warnings for enabling Werror #502
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nsingh-habana
changed the title
nsingh-habana
force-pushed
the
fix_compilation_warnings
branch
from
fa7f5c0 to
05c5c70
Compare
1. Tuple bindings passed by ref to lambda calls not natively handled by C++17 2. LOG_THREAD re-definition 3. Ignore unused build args
nsingh-habana
force-pushed
the
fix_compilation_warnings
branch
from
05c5c70 to
57ff558
Compare
1) Add -Wno-unknown-warning-option to handle "unknown warning option '-Wno-implicit-float-size-conversion'" 2) Add Winline to "don't raise error for this warning list" for Werror
rolandschulz
approved these changes
Sep 16, 2025
tdeng5
approved these changes
Sep 16, 2025
nsingh-habana
changed the title
leonling-lly
pushed a commit
to leonling-lly/cutlass-sycl
that referenced
this pull request
Sep 19, 2025
The goal is to make warnings throw error during the building process. For this, all compilation warnings are to be handled, and any non-serious unavoidable warnings have to be suppressed. --------- Co-authored-by: Joy, Albin <albin.joy@intel.com>
sunjiweiswift
pushed a commit
to sunjiweiswift/cutlass-sycl
that referenced
this pull request
Sep 22, 2025
The goal is to make warnings throw error during the building process. For this, all compilation warnings are to be handled, and any non-serious unavoidable warnings have to be suppressed. --------- Co-authored-by: Joy, Albin <albin.joy@intel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal is to make warnings throw error during the building process.
For this, all compilation warnings are to be handled, and any non-serious unavoidable warnings have to be suppressed.