Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add maintenance warning to README #420

Merged
merged 1 commit into from
May 4, 2024
Merged

Conversation

brandur
Copy link
Member

@brandur brandur commented May 4, 2024

Given that I rarely look at Committee anymore and other maintainers have
dropped off the project as well, add a maintenance warning to the README
indicating that new users should look elsewhere.

Given that I rarely look at Committee anymore and other maintainers have
dropped off the project as well, add a maintenance warning to the README
indicating that new users should look elsewhere.
@brandur brandur merged commit 225b60e into master May 4, 2024
6 checks passed
@brandur brandur deleted the brandur-readme-warning branch May 4, 2024 17:47
@ydah
Copy link
Member

ydah commented May 7, 2024

@brandur If you thinks so I would like to maintain or help this project. Because I am (and we are) a frequent user of this project.

@brandur
Copy link
Member Author

brandur commented May 10, 2024

@ydah Thank you for the kind offer! You have quite the maintenance history, so we'd be very excited to have you on board!

Just given that it would seem like poor practice to immediately add anybody to the org, would you mind if we ran a short trial period where we took a look at a few open changes?

In particular, we have a request in #417 where an active Committee user is trying to get a change in. Do you think you could take a look at that pull request and leave a review on it?

After that, happy to add you to the org and then we can revert the README note I added here.

Thank you!

@ydah
Copy link
Member

ydah commented May 10, 2024

Just given that it would seem like poor practice to immediately add anybody to the org, would you mind if we ran a short trial period where we took a look at a few open changes?
In particular, we have a request in #417 where an active Committee user is trying to get a change in. Do you think you could take a look at that pull request and leave a review on it?

Thank you for considering it even though it was a sudden offer!
No problem. I left a comment about #417 .

@brandur
Copy link
Member Author

brandur commented May 13, 2024

Hi @ydah, thanks for looking into that.

I've added you as a member in GitHub and owner for the gem on RubyGems.

When you have a chance, why don't you try:

  1. When satisfied with changes, merging Rename parameter_overwite_by_rails_rule to parameter_overwrite_by_rails_rule #396 and Add option to permit validation when schema and data are empty #417.
  2. Follow the README instructions to cut new release: https://github.com/interagent/committee?tab=readme-ov-file#release
  3. Revert the changes in this PR so that the project no longer reads as unmaintained.

Thanks!

@ydah
Copy link
Member

ydah commented May 13, 2024

Hi @brandur, thank you for inviting me!
I see. I will proceed with the release and the revert of this PR change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants