Add i18n support to search/inside template #5137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdrini
approved these changes
May 4, 2021
There was a problem hiding this comment.
Good catch! Confirmed working correctly now for http://testing.openlibrary.org/search/inside?q=%22%3Cscript%3Ealert%28100%29%3C%2Fscript%3E%22
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Efforts towards i18n - #791
Add i18n support for title in search/inside template.
Fix escaped html tag.
Technical
Testing
Screenshot
Before: No hits message with
strongtag escapedAfter: No hits message with escaped query and strong format
Stakeholders
@cdrini