Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link to author identifier docs from reading stats page #5437 #5445

Merged
merged 1 commit into from
Jul 20, 2021
Merged

Link to author identifier docs from reading stats page #5437 #5445

merged 1 commit into from
Jul 20, 2021

Conversation

Atharva-Shinde
Copy link
Contributor

Closes #5437

Link to author identifier docs from reading stats page

Technical

changed
Demographic statistics powered by Wikidata. Here's a sample of the query used.
To

Demographic statistics powered by Wikidata. Here's a sample of the query used.
Improve these stats by adding the Wikidata author identifier following (these instructions {link}).

Testing

Stakeholders

@RayBB
Copy link
Collaborator

RayBB commented Jul 20, 2021

@Atharva-Shinde I tested it locally and it looks good. Generally you should add a screenshot to your PR when it's a change that impacts the GUI but I've added one here for you.

image

We'll need one of the maintainers to review/merge it like @jamesachamp

I'd highly recommend coming to the community call that happens Tuesdays at 10AM PT (more info here) to share you change and see what's going on.

@Atharva-Shinde
Copy link
Contributor Author

Ok I'll keep that in mind that adding a screenshot is a good convention,
And I'll definitely attend the community.
So we just have to wait isn't it??
If there are more good first issues please let me know as i would be happy to contribute more...

@mekarpeles mekarpeles self-assigned this Jul 20, 2021
@mekarpeles mekarpeles merged commit 1467194 into internetarchive:master Jul 20, 2021
@mekarpeles
Copy link
Member

ty! lgtm

@RayBB
Copy link
Collaborator

RayBB commented Jul 20, 2021

@Atharva-Shinde you pr was merged 🎉
I recommend you submit a request to join our slack (instructions here https://openlibrary.org/volunteer#engineering) so it's a little easier for us to communicate.

@Atharva-Shinde
Copy link
Contributor Author

Atharva-Shinde commented Jul 20, 2021

Thanks a lot @RayBB and @mekarpeles this was my first ever Pull Request and that too successfully merged!!!!
Sure I will right away send request to join the slack.

@Atharva-Shinde
Copy link
Contributor Author

Atharva-Shinde commented Jul 21, 2021

@RayBB I have not received any email regarding slack channel, can you please give me the link to join the slack??

@RayBB
Copy link
Collaborator

RayBB commented Jul 21, 2021

@Atharva-Shinde did you send a request following the instructions here? https://openlibrary.org/volunteer#engineering

There is no public link to share. People are added by email after you send them an email via the instructions above. Usually @mekarpeles or other staff will respond to add you.

@Atharva-Shinde
Copy link
Contributor Author

I got an email just 11 minutes ago,
@RayBB thanks again:)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Link to author identifier docs from reading stats page
3 participants