Add cursor: pointer non-standard buttons
#8578
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gn up and other related buttons
jimchamp
changed the title
cursor: pointer non-standard buttons
jimchamp
approved these changes
Dec 22, 2023
There was a problem hiding this comment.
@Abhishektharu, thanks and sorry for the delay!
This looks like it will only affect buttons with class larger. This is fine, as #8578 should have been closed as a duplicate of #1184.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8578 +/- ##
=======================================
Coverage 16.51% 16.51%
=======================================
Files 85 85
Lines 4456 4456
Branches 782 782
=======================================
Hits 736 736
Misses 3227 3227
Partials 493 493 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… related buttons
Closes #8567
added #8567 cursor type to cursor: pointer to login sign up and other related buttons
Technical
a hand tool (pointer) will be seen whenever we hover over login, signup and other related buttons.
Testing
Hover over Login and signup buttons
Screenshot
Stakeholders
@jimchamp @mekarpeles @cdrini