DOI field fixes

[lnielsen]

The DOI field has several issue.

To test it you need to enable DOI minting:

# my-site/invenio.cfg
DATACITE_ENABLED = True
DATACITE_PREFIX = "10.1234"
DATACITE_USERNAME = "INVALID"
DATACITE_PASSWORD = "INVALID"
DATACITE_TEST_MODE = True

Serialization/Deserialization/Form state

1. Form initialisation

• pids: state of "Do you already have a DOI for this upload? Yes/No" is not preserved through reloads invenio-rdm-records#843
• ux: new version with managed DOI does not start in managed DOI state invenio-rdm-records#846

It should be possible to initialise the form to start either yes or no mode:

# Yes
{"pids": {"doi": {"provider": "external", "identifier": ""}}}
# No
{"pids": {}}

Example: If a new version is created from a previous version with a minted DOI, then we should start in "No" mode.
Example: For a new deposit we start in "Yes"-mode.
The backend should be able to control the initial state based on the data it's sending.

2. Sending data to the REST API

# Yes with an value (empty string allow)
{"pids": {"doi": {"provider": "external", "identifier": "<value>"}}}
# No - without a reserved DOI
{"pids": {}}
# No - with a reserved DOI
{"pids": {"doi": {"provider": "datacite", "identifier": "<value>", "client": datacite}}}

3. Receiving data from the REST API

The form should not start modifying the data it receives from the backend. E.g. it looks like that if you send:

{"pids": {"doi": {"provider": "external", "identifier": ""}}} it gets changed to {"pids": {"doi": {"provider": "external"}}}.

Error messages in form feedback

• pid: publishing a record with an already existing external DOI causes error invenio-rdm-records#840
• pids: saving draft without an external DOI does not shown an error invenio-rdm-records#841

Error messages should be displayed in the FormFeedback with correct label.

Example:
"Digital object identifier: Missing DOI for field."

The API delivers error messages as either (most errors or on the pids.doi):

{"errors": [
        {
            "field": "pids.doi",
            "messages": ["...." ]
        },
        {
            "field": "pids",
            "messages": ["...." ]
        },
]}

Error messages on field

• deposit: errors on DOI field is not reported invenio-app-rdm#1129

Error messages should be displayed on the field. Note the error can likely be put on the text field for the unmanaged DOI.

vs