Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui: redesign followups 9 #5460

Merged
merged 11 commits into from
Jan 10, 2024
Merged

ui: redesign followups 9 #5460

merged 11 commits into from
Jan 10, 2024

Commits on Jan 9, 2024

  1. fix(ui): fix typing of usGalleryImages

    For some reason `ReturnType<typeof useListImagesQuery>` isn't working correctly, and destructuring `queryResult` it results in `any`, when the hook is used.
    
    I've removed the explicit return typing so that consumers of the hook get correct types.
    psychedelicious committed Jan 9, 2024
    Configuration menu
    Copy the full SHA
    bee0c0d View commit details
    Browse the repository at this point in the history
  2. feat(ui): remove unnecessary tabChanged listener

    This was needed when we didn't support SDXL on canvas.
    psychedelicious committed Jan 9, 2024
    Configuration menu
    Copy the full SHA
    9be9b40 View commit details
    Browse the repository at this point in the history
  3. feat(ui): do not optimize size when changing between models with same…

    … base model
    
    There's a challenge to accomplish this due to our slice structure - the model is stored in `generationSlice`, but `canvasSlice` also needs to have awareness of it. For example, when the model changes, the canvas slice doesn't know what the previous model was, so it doesn't know whether or not to optimize the size.
    
    This means we need to lift the "should we optimize size" information up. To do this, the `modelChanged` action creator accepts the previous model as an optional second arg.
    
    Now the canvas has access to both the previous model and new model selection, and can decide whether or not it should optimize its size setting in the same way that the generation slice does.
    
    Closes  #5452
    psychedelicious committed Jan 9, 2024
    Configuration menu
    Copy the full SHA
    dc4e226 View commit details
    Browse the repository at this point in the history
  4. fix(ui): canvas bbox number input wonky

    It was rounding dimensions when it shouldn't.
    
    Closes #5453
    psychedelicious committed Jan 9, 2024
    Configuration menu
    Copy the full SHA
    dba7d19 View commit details
    Browse the repository at this point in the history
  5. feat(ui): move canvas tool to nanostores

    I was troubleshooting a hotkeys issue on canvas and thought I had broken the tool logic in a past change so I redid it moving it to nanostores. In the end, the issue was an upstream but with the hotkeys library, but I like having tool in nanostores so I'm leaving it.
    
    It's ephemeral interaction state anyways, doesn't need to be in redux.
    psychedelicious committed Jan 9, 2024
    Configuration menu
    Copy the full SHA
    00b2373 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    2491fea View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    5756bfe View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    38743c7 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    c96960c View commit details
    Browse the repository at this point in the history
  10. chore(ui): lint

    psychedelicious committed Jan 9, 2024
    Configuration menu
    Copy the full SHA
    c37061e View commit details
    Browse the repository at this point in the history

Commits on Jan 10, 2024

  1. Configuration menu
    Copy the full SHA
    028b404 View commit details
    Browse the repository at this point in the history