Fix "recall all" when loras, controls, or high res fix are not present #6211
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chainchompa
requested review from
psychedelicious,
blessedcoolant,
maryhipp and
hipsterusername
as code owners
psychedelicious
approved these changes
Apr 14, 2024
psychedelicious
force-pushed
the
chainchompa/recall-hrf-remove-concepts
branch
from
5c0d700 to
370a64c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Currently "recall all" won't remove controls or hrf when they aren't used in the image, updates to set them to false or an empty array when not present. Loras were the same way but caught downstream elsewhere so also updated those
Related Issues / Discussions
Closes #6210
QA Instructions
Merge Plan
Checklist