Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

we aren't registering title changes in local autosave #1599

Closed
hamilton opened this issue Mar 11, 2019 · 1 comment
Closed

we aren't registering title changes in local autosave #1599

hamilton opened this issue Mar 11, 2019 · 1 comment
Labels
bug client UX saving

Comments

@hamilton
Copy link
Contributor

hamilton commented Mar 11, 2019 •
edited
Loading

I hope we can add the title to (local) autosave ASAP, since I think to users it would appear to be a bug.
@hamilton hamilton changed the title we aren't registering title changes in autosave, so in some cases we aren't saving hte title we aren't registering title changes in local autosave Mar 11, 2019
@wlach wlach added the saving label Mar 27, 2019
@bcolloran
Copy link
Contributor

did we do this? @wlach i think your previous autosave PR now triggers on changes in the editor or title?

wlach added a commit to wlach/iodide that referenced this issue May 15, 2019
@wlach
Reworking of the save/autosave implementation on client
e22f836 
* Remove most of the client-side autosave implementation. It is now a simple
  caching layer that saves pending changes to the server. If a user is not
  logged in or it is not their notebook, changes are no longer persisted.
* Submit parent information with notebook on save and respond appropriately
  if notebook is out of date (rest of iodide-project#1569)
* Detect case where server logged out either due to user intervention
  or session expiry, and offer to recover (fixes iodide-project#1680)
* Titles are now autosaved locally (fixes iodide-project#1599)
* All operations which touch the redux store are now redux actions
* Reorganize directory structure and naming to be more intuitive
wlach added a commit to wlach/iodide that referenced this issue May 15, 2019
@wlach
Reworking of the save/autosave implementation on client
0ab33fa 
* Remove most of the client-side autosave implementation. It is now a simple
  caching layer that saves pending changes to the server. If a user is not
  logged in or it is not their notebook, changes are no longer persisted.
* Submit parent information with notebook on save and respond appropriately
  if notebook is out of date (rest of iodide-project#1569)
* Detect case where server logged out either due to user intervention
  or session expiry, and offer to recover (fixes iodide-project#1680)
* Titles are now autosaved locally (fixes iodide-project#1599)
* All operations which touch the redux store are now redux actions
* Reorganize directory structure and naming to be more intuitive
wlach added a commit to wlach/iodide that referenced this issue May 15, 2019
@wlach
Reworking of the save/autosave implementation on client
337d58c 
* Remove most of the client-side autosave implementation. It is now a simple
  caching layer that saves pending changes to the server. If a user is not
  logged in or it is not their notebook, changes are no longer persisted.
* Submit parent information with notebook on save and respond appropriately
  if notebook is out of date (rest of iodide-project#1569)
* Detect case where server logged out either due to user intervention
  or session expiry, and offer to recover (fixes iodide-project#1680)
* Titles are now autosaved locally (fixes iodide-project#1599)
* All operations which touch the redux store are now redux actions
* Reorganize directory structure and naming to be more intuitive
wlach added a commit to wlach/iodide that referenced this issue May 15, 2019
@wlach
Reworking of the save/autosave implementation on client
6794e29 
* Remove most of the client-side autosave implementation. It is now a simple
  caching layer that saves pending changes to the server. If a user is not
  logged in or it is not their notebook, changes are no longer persisted.
* Submit parent information with notebook on save and respond appropriately
  if notebook is out of date (rest of iodide-project#1569)
* Detect case where server logged out either due to user intervention
  or session expiry, and offer to recover (fixes iodide-project#1680)
* Titles are now autosaved locally (fixes iodide-project#1599)
* All operations which touch the redux store are now redux actions
* Reorganize directory structure and naming to be more intuitive
wlach added a commit to wlach/iodide that referenced this issue May 15, 2019
@wlach
Reworking of the save/autosave implementation on client
040d66a 
* Remove most of the client-side autosave implementation. It is now a simple
  caching layer that saves pending changes to the server. If a user is not
  logged in or it is not their notebook, changes are no longer persisted.
* Submit parent information with notebook on save and respond appropriately
  if notebook is out of date (rest of iodide-project#1569)
* Detect case where server logged out either due to user intervention
  or session expiry, and offer to recover (fixes iodide-project#1680)
* Titles are now autosaved locally (fixes iodide-project#1599)
* All operations which touch the redux store are now redux actions
* Reorganize directory structure and naming to be more intuitive
wlach added a commit that referenced this issue May 15, 2019
@wlach
Reworking of the save/autosave implementation on client
029a40a 
* Remove most of the client-side autosave implementation. It is now a simple
  caching layer that saves pending changes to the server. If a user is not
  logged in or it is not their notebook, changes are no longer persisted.
* Submit parent information with notebook on save and respond appropriately
  if notebook is out of date (rest of #1569)
* Detect case where server logged out either due to user intervention
  or session expiry, and offer to recover (fixes #1680)
* Titles are now autosaved locally (fixes #1599)
* All operations which touch the redux store are now redux actions
* Reorganize directory structure and naming to be more intuitive
wlach added a commit to wlach/iodide that referenced this issue May 16, 2019
@wlach
Reworking of the save/autosave implementation on client
f751eae 
* Remove most of the client-side autosave implementation. It is now a simple
  caching layer that saves pending changes to the server. If a user is not
  logged in or it is not their notebook, changes are no longer persisted.
* Submit parent information with notebook on save and respond appropriately
  if notebook is out of date (rest of iodide-project#1569)
* Detect case where server logged out either due to user intervention
  or session expiry, and offer to recover (fixes iodide-project#1680)
* Titles are now autosaved locally (fixes iodide-project#1599)
* All operations which touch the redux store are now redux actions
* Reorganize directory structure and naming to be more intuitive
wlach added a commit to wlach/iodide that referenced this issue May 21, 2019
@wlach
Reworking of the save/autosave implementation on client
bfacf39 
* Remove most of the client-side autosave implementation. It is now a simple
  caching layer that saves pending changes to the server. If a user is not
  logged in or it is not their notebook, changes are no longer persisted.
* Submit parent information with notebook on save and respond appropriately
  if notebook is out of date (rest of iodide-project#1569)
* Detect case where server logged out either due to user intervention
  or session expiry, and offer to recover (fixes iodide-project#1680)
* Titles are now autosaved locally (fixes iodide-project#1599)
* All operations which touch the redux store are now redux actions
* Reorganize directory structure and naming to be more intuitive
wlach added a commit to wlach/iodide that referenced this issue May 21, 2019
@wlach
Reworking of the save/autosave implementation on client
ffea232 
* Remove most of the client-side autosave implementation. It is now a simple
  caching layer that saves pending changes to the server. If a user is not
  logged in or it is not their notebook, changes are no longer persisted.
* Submit parent information with notebook on save and respond appropriately
  if notebook is out of date (rest of iodide-project#1569)
* Detect case where server logged out either due to user intervention
  or session expiry, and offer to recover (fixes iodide-project#1680)
* Titles are now autosaved locally (fixes iodide-project#1599)
* All operations which touch the redux store are now redux actions
* Reorganize directory structure and naming to be more intuitive
wlach added a commit to wlach/iodide that referenced this issue May 23, 2019
@wlach
Reworking of the save/autosave implementation on client
920f464 
* Remove most of the client-side autosave implementation. It is now a simple
  caching layer that saves pending changes to the server. If a user is not
  logged in or it is not their notebook, changes are no longer persisted.
* Submit parent information with notebook on save and respond appropriately
  if notebook is out of date (rest of iodide-project#1569)
* Detect case where server logged out either due to user intervention
  or session expiry, and offer to recover (fixes iodide-project#1680)
* Titles are now autosaved locally (fixes iodide-project#1599)
* All operations which touch the redux store are now redux actions
* Reorganize directory structure and naming to be more intuitive
wlach added a commit to wlach/iodide that referenced this issue May 27, 2019
@wlach
Reworking of the save/autosave implementation on client
3d5b3db 
* Remove most of the client-side autosave implementation. It is now a simple
  caching layer that saves pending changes to the server. If a user is not
  logged in or it is not their notebook, changes are no longer persisted.
* Submit parent information with notebook on save and respond appropriately
  if notebook is out of date (rest of iodide-project#1569)
* Detect case where server logged out either due to user intervention
  or session expiry, and offer to recover (fixes iodide-project#1680)
* Titles are now autosaved locally (fixes iodide-project#1599)
* All operations which touch the redux store are now redux actions
* Reorganize directory structure and naming to be more intuitive
wlach added a commit to wlach/iodide that referenced this issue May 27, 2019
@wlach
Reworking of the save/autosave implementation on client
bdeb9c5 
* Remove most of the client-side autosave implementation. It is now a simple
  caching layer that saves pending changes to the server. If a user is not
  logged in or it is not their notebook, changes are no longer persisted.
* Submit parent information with notebook on save and respond appropriately
  if notebook is out of date (rest of iodide-project#1569)
* Detect case where server logged out either due to user intervention
  or session expiry, and offer to recover (fixes iodide-project#1680)
* Titles are now autosaved locally (fixes iodide-project#1599)
* All operations which touch the redux store are now redux actions
* Reorganize directory structure and naming to be more intuitive
wlach added a commit to wlach/iodide that referenced this issue May 27, 2019
@wlach
Reworking of the save/autosave implementation on client
60a57dd 
* Remove most of the client-side autosave implementation. It is now a simple
  caching layer that saves pending changes to the server. If a user is not
  logged in or it is not their notebook, changes are no longer persisted.
* Submit parent information with notebook on save and respond appropriately
  if notebook is out of date (rest of iodide-project#1569)
* Detect case where server logged out either due to user intervention
  or session expiry, and offer to recover (fixes iodide-project#1680)
* Titles are now autosaved locally (fixes iodide-project#1599)
* All operations which touch the redux store are now redux actions
* Reorganize directory structure and naming to be more intuitive
@wlach wlach closed this as completed in be29b69 May 28, 2019
wlach added a commit that referenced this issue May 30, 2019
@wlach
Reworking of the save/autosave implementation on client
7ffb2f3 
* Remove most of the client-side autosave implementation. It is now a simple
  caching layer that saves pending changes to the server. If a user is not
  logged in or it is not their notebook, changes are no longer persisted.
* Submit parent information with notebook on save and respond appropriately
  if notebook is out of date (rest of #1569)
* Detect case where server logged out either due to user intervention
  or session expiry, and offer to recover (fixes #1680)
* Titles are now autosaved locally (fixes #1599)
* All operations which touch the redux store are now redux actions
* Reorganize directory structure and naming to be more intuitive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug client UX saving
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@wlach @hamilton @bcolloran