-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Should detect somehow if no longer logged in #1680
Labels
Comments
wlach
added a commit
to wlach/iodide
that referenced
this issue
May 7, 2019
* Operations which touch the redux store are now redux actions, reduces circular imports * Reorganize directory structure and naming to be more intuitive * Submit parent information with notebook on save and respond appropriately if notebook is out of date (rest of iodide-project#1569) * Detect case where server logged out either due to user intervention or session expiry, and offer to recover (fixes iodide-project#1680)
wlach
added a commit
to wlach/iodide
that referenced
this issue
May 8, 2019
* Operations which touch the redux store are now redux actions, reduces circular imports * Reorganize directory structure and naming to be more intuitive * Submit parent information with notebook on save and respond appropriately if notebook is out of date (rest of iodide-project#1569) * Detect case where server logged out either due to user intervention or session expiry, and offer to recover (fixes iodide-project#1680)
wlach
added a commit
to wlach/iodide
that referenced
this issue
May 15, 2019
* Remove most of the client-side autosave implementation. It is now a simple caching layer that saves pending changes to the server. If a user is not logged in or it is not their notebook, changes are no longer persisted. * Submit parent information with notebook on save and respond appropriately if notebook is out of date (rest of iodide-project#1569) * Detect case where server logged out either due to user intervention or session expiry, and offer to recover (fixes iodide-project#1680) * Titles are now autosaved locally (fixes iodide-project#1599) * All operations which touch the redux store are now redux actions * Reorganize directory structure and naming to be more intuitive
wlach
added a commit
to wlach/iodide
that referenced
this issue
May 15, 2019
* Remove most of the client-side autosave implementation. It is now a simple caching layer that saves pending changes to the server. If a user is not logged in or it is not their notebook, changes are no longer persisted. * Submit parent information with notebook on save and respond appropriately if notebook is out of date (rest of iodide-project#1569) * Detect case where server logged out either due to user intervention or session expiry, and offer to recover (fixes iodide-project#1680) * Titles are now autosaved locally (fixes iodide-project#1599) * All operations which touch the redux store are now redux actions * Reorganize directory structure and naming to be more intuitive
wlach
added a commit
to wlach/iodide
that referenced
this issue
May 15, 2019
* Remove most of the client-side autosave implementation. It is now a simple caching layer that saves pending changes to the server. If a user is not logged in or it is not their notebook, changes are no longer persisted. * Submit parent information with notebook on save and respond appropriately if notebook is out of date (rest of iodide-project#1569) * Detect case where server logged out either due to user intervention or session expiry, and offer to recover (fixes iodide-project#1680) * Titles are now autosaved locally (fixes iodide-project#1599) * All operations which touch the redux store are now redux actions * Reorganize directory structure and naming to be more intuitive
wlach
added a commit
to wlach/iodide
that referenced
this issue
May 15, 2019
* Remove most of the client-side autosave implementation. It is now a simple caching layer that saves pending changes to the server. If a user is not logged in or it is not their notebook, changes are no longer persisted. * Submit parent information with notebook on save and respond appropriately if notebook is out of date (rest of iodide-project#1569) * Detect case where server logged out either due to user intervention or session expiry, and offer to recover (fixes iodide-project#1680) * Titles are now autosaved locally (fixes iodide-project#1599) * All operations which touch the redux store are now redux actions * Reorganize directory structure and naming to be more intuitive
wlach
added a commit
to wlach/iodide
that referenced
this issue
May 15, 2019
* Remove most of the client-side autosave implementation. It is now a simple caching layer that saves pending changes to the server. If a user is not logged in or it is not their notebook, changes are no longer persisted. * Submit parent information with notebook on save and respond appropriately if notebook is out of date (rest of iodide-project#1569) * Detect case where server logged out either due to user intervention or session expiry, and offer to recover (fixes iodide-project#1680) * Titles are now autosaved locally (fixes iodide-project#1599) * All operations which touch the redux store are now redux actions * Reorganize directory structure and naming to be more intuitive
wlach
added a commit
that referenced
this issue
May 15, 2019
* Remove most of the client-side autosave implementation. It is now a simple caching layer that saves pending changes to the server. If a user is not logged in or it is not their notebook, changes are no longer persisted. * Submit parent information with notebook on save and respond appropriately if notebook is out of date (rest of #1569) * Detect case where server logged out either due to user intervention or session expiry, and offer to recover (fixes #1680) * Titles are now autosaved locally (fixes #1599) * All operations which touch the redux store are now redux actions * Reorganize directory structure and naming to be more intuitive
wlach
added a commit
to wlach/iodide
that referenced
this issue
May 16, 2019
* Remove most of the client-side autosave implementation. It is now a simple caching layer that saves pending changes to the server. If a user is not logged in or it is not their notebook, changes are no longer persisted. * Submit parent information with notebook on save and respond appropriately if notebook is out of date (rest of iodide-project#1569) * Detect case where server logged out either due to user intervention or session expiry, and offer to recover (fixes iodide-project#1680) * Titles are now autosaved locally (fixes iodide-project#1599) * All operations which touch the redux store are now redux actions * Reorganize directory structure and naming to be more intuitive
wlach
added a commit
to wlach/iodide
that referenced
this issue
May 21, 2019
* Remove most of the client-side autosave implementation. It is now a simple caching layer that saves pending changes to the server. If a user is not logged in or it is not their notebook, changes are no longer persisted. * Submit parent information with notebook on save and respond appropriately if notebook is out of date (rest of iodide-project#1569) * Detect case where server logged out either due to user intervention or session expiry, and offer to recover (fixes iodide-project#1680) * Titles are now autosaved locally (fixes iodide-project#1599) * All operations which touch the redux store are now redux actions * Reorganize directory structure and naming to be more intuitive
wlach
added a commit
to wlach/iodide
that referenced
this issue
May 21, 2019
* Remove most of the client-side autosave implementation. It is now a simple caching layer that saves pending changes to the server. If a user is not logged in or it is not their notebook, changes are no longer persisted. * Submit parent information with notebook on save and respond appropriately if notebook is out of date (rest of iodide-project#1569) * Detect case where server logged out either due to user intervention or session expiry, and offer to recover (fixes iodide-project#1680) * Titles are now autosaved locally (fixes iodide-project#1599) * All operations which touch the redux store are now redux actions * Reorganize directory structure and naming to be more intuitive
wlach
added a commit
to wlach/iodide
that referenced
this issue
May 23, 2019
* Remove most of the client-side autosave implementation. It is now a simple caching layer that saves pending changes to the server. If a user is not logged in or it is not their notebook, changes are no longer persisted. * Submit parent information with notebook on save and respond appropriately if notebook is out of date (rest of iodide-project#1569) * Detect case where server logged out either due to user intervention or session expiry, and offer to recover (fixes iodide-project#1680) * Titles are now autosaved locally (fixes iodide-project#1599) * All operations which touch the redux store are now redux actions * Reorganize directory structure and naming to be more intuitive
wlach
added a commit
to wlach/iodide
that referenced
this issue
May 27, 2019
* Remove most of the client-side autosave implementation. It is now a simple caching layer that saves pending changes to the server. If a user is not logged in or it is not their notebook, changes are no longer persisted. * Submit parent information with notebook on save and respond appropriately if notebook is out of date (rest of iodide-project#1569) * Detect case where server logged out either due to user intervention or session expiry, and offer to recover (fixes iodide-project#1680) * Titles are now autosaved locally (fixes iodide-project#1599) * All operations which touch the redux store are now redux actions * Reorganize directory structure and naming to be more intuitive
wlach
added a commit
to wlach/iodide
that referenced
this issue
May 27, 2019
* Remove most of the client-side autosave implementation. It is now a simple caching layer that saves pending changes to the server. If a user is not logged in or it is not their notebook, changes are no longer persisted. * Submit parent information with notebook on save and respond appropriately if notebook is out of date (rest of iodide-project#1569) * Detect case where server logged out either due to user intervention or session expiry, and offer to recover (fixes iodide-project#1680) * Titles are now autosaved locally (fixes iodide-project#1599) * All operations which touch the redux store are now redux actions * Reorganize directory structure and naming to be more intuitive
wlach
added a commit
to wlach/iodide
that referenced
this issue
May 27, 2019
* Remove most of the client-side autosave implementation. It is now a simple caching layer that saves pending changes to the server. If a user is not logged in or it is not their notebook, changes are no longer persisted. * Submit parent information with notebook on save and respond appropriately if notebook is out of date (rest of iodide-project#1569) * Detect case where server logged out either due to user intervention or session expiry, and offer to recover (fixes iodide-project#1680) * Titles are now autosaved locally (fixes iodide-project#1599) * All operations which touch the redux store are now redux actions * Reorganize directory structure and naming to be more intuitive
wlach
added a commit
that referenced
this issue
May 30, 2019
* Remove most of the client-side autosave implementation. It is now a simple caching layer that saves pending changes to the server. If a user is not logged in or it is not their notebook, changes are no longer persisted. * Submit parent information with notebook on save and respond appropriately if notebook is out of date (rest of #1569) * Detect case where server logged out either due to user intervention or session expiry, and offer to recover (fixes #1680) * Titles are now autosaved locally (fixes #1599) * All operations which touch the redux store are now redux actions * Reorganize directory structure and naming to be more intuitive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We should detect somehow if the user's session has expired, or we otherwise can't save for that reason. Right now we claim "we'll keep trying" which isn't really true (if the user manually logs in elsewhere, it will work, but that's pretty obscure...)
The text was updated successfully, but these errors were encountered: