Feat split tooling #465
Merged
Feat split tooling #465
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this splits angular-toolkit into two packages. @ionic/angular-toolkit provides schematics for angular. @ionic/cordova-builders provides a collection of custom builders for ionic/angular + cordova app BREAKING CHANGE: ionic/angular + cordova users will now need to install @ionic/cordova-builders and update their angular.json to reflect the new package name
mhartington
added a commit
that referenced
this pull request
Jan 18, 2022
* feat: split packages and create mono-repo this splits angular-toolkit into two packages. @ionic/angular-toolkit provides schematics for angular. @ionic/cordova-builders provides a collection of custom builders for ionic/angular + cordova app BREAKING CHANGE: ionic/angular + cordova users will now need to install @ionic/cordova-builders and update their angular.json to reflect the new package name * chore(): fix package description
Closed
|
This may be a dumb question, but if I have an ionic/capacitor app but I still use cordova plugins can I go the simple route or do I need the |
|
You do not need the |
|
You might consider updating the Readme.md file for angular-toolkit to mention the instructions for this change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This splits out the builders and schematics into two separate packages. The reason behind this is that the schematics and builders always had separate goals. This will update
@ionic/angular-toolkitto only include the schematics for@ionic/angularapps, no builders.A new package
@ionic/cordova-builderswill be created that will have all the custom build tools needed for older Ionic/Cordova apps.Migration
For folks using
@ionic/angularand Capacitor, you can update to the latest (once release) and remove the olderionic-cordova-buildentries from your angular.json"devServerTarget": "app:serve:ci" } } - }, - "ionic-cordova-build": { - "builder": "@ionic/angular-toolkit:cordova-build", - "options": { - "browserTarget": "app:build" - }, - "configurations": { - "production": { - "browserTarget": "app:build:production" - } - } - }, - "ionic-cordova-serve": { - "builder": "@ionic/angular-toolkit:cordova-serve", - "options": { - "cordovaBuildTarget": "app:ionic-cordova-build", - "devServerTarget": "app:serve" - }, - "configurations": { - "production": { - "cordovaBuildTarget": "app:ionic-cordova-build:production", - "devServerTarget": "app:serve:production" - } - } } } }And you're good to go! You'll still have access to the schematics so things like
ionic g pagewill work as expected.For Ionic/Cordova users, you will need to install the new
@ionic/cordova-builderspackage.Then you can update the existing ionic-cordova-build task to call the new package.
} }, "ionic-cordova-build": { - "builder": "@ionic/angular-toolkit:cordova-build", + "builder": "@ionic/cordova-builders:cordova-build", "options": { "browserTarget": "app:build" }, @@ -155,7 +155,7 @@ } }, "ionic-cordova-serve": { - "builder": "@ionic/angular-toolkit:cordova-serve", + "builder": "@ionic/cordova-builders:cordova-serve", "options": { "cordovaBuildTarget": "app:ionic-cordova-build", "devServerTarget": "app:serve"Everything should still work as expected, but if you do run into any problems, please open an issue 😄