Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add _alwaysRunsAtForegroundPriority setting #110

Merged
merged 1 commit into from
Jun 5, 2018
Merged

add _alwaysRunsAtForegroundPriority setting #110

merged 1 commit into from
Jun 5, 2018

Conversation

jacquesdev
Copy link
Contributor

@jacquesdev jacquesdev commented Jun 4, 2018

Creating this updated PR on behalf of @ghenry22, since the original #45 had conflicts. (Literally just a copy and paste job)

Closes #45
Closes #57

@genry22 - if this has your blessing please comment here so that @mlynch can merge it.

@ghenry22
Copy link
Contributor

ghenry22 commented Jun 5, 2018

I believe you need the keywindow changes from the original PR as well for proper background operation.

@jacquesdev
Copy link
Contributor Author

Hi @ghenry22. I forked the current master, and realised the keywindow changes are already in the project, so no additional changes required.

I guess there was another PR from before where it was added.

Hopefully this PR will save you some time so that you don’t have to resolve conflicts. Thanks for your updates by the way!

@ghenry22
Copy link
Contributor

ghenry22 commented Jun 5, 2018

ah right someone already cloned my selectable port PR and included the keywindow settings by the look of it.

@mlynch mlynch merged commit 0ec0e50 into ionic-team:master Jun 5, 2018
@mlynch
Copy link
Contributor

mlynch commented Jun 5, 2018

Thanks! Merged and the other issue is closed

@HugoHeneault
Copy link

There also is this PR that might have been missed: https://github.com/ionic-team/cordova-plugin-ionic-webview/pull/58/files :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants