Skip to content
This repository was archived by the owner on May 1, 2020. It is now read-only.

Conversation

ufolux
Copy link
Contributor

@ufolux ufolux commented Aug 31, 2017

Short description of what this resolves:

This commit fix the problem that the --nolivereload or -d flag doesn't work when user excute ionic serve -d or ionic serve --nolivereload command with ion-cli

Changes proposed in this pull request:

  • The injectNotificationScript can be executed, only when user set a true value for config.useLiveReload

Fixes: #962

@ufolux ufolux changed the title fix --nolivereload flag not work bug fix:#962 --nolivereload flag not work bug Sep 4, 2017
@danbucholtz danbucholtz merged commit d62f5da into ionic-team:master Oct 12, 2017
@danbucholtz
Copy link
Contributor

@ufolux,

Thanks for the PR.

Thanks,
Dan

@ufolux
Copy link
Contributor Author

ufolux commented Oct 13, 2017

😁

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants