Skip to content
This repository was archived by the owner on May 1, 2020. It is now read-only.

fix(): add global.scss to config #41

Closed
wants to merge 1 commit into from
Closed

fix(): add global.scss to config #41

wants to merge 1 commit into from

Conversation

mhartington
Copy link
Contributor

No description provided.

@mhartington mhartington mentioned this pull request Sep 29, 2016
Closed
@ramonornela
Copy link

ramonornela commented Sep 30, 2016 •
edited
Loading

@mhartington not exists any treatment to option globalSassFiles in sass 😉

@ramonornela
Copy link

My workaround https://github.com/ramonornela/ionic_playground_rc0/blob/master/config/sass.config.js and https://github.com/ramonornela/ionic_playground_rc0/blob/master/package.json#L43

ramonornela referenced this pull request in ionic-team/ionic2-app-base Sep 30, 2016
@amuramoto @brandyscarney
feat(theme): add global.scss (#80)
201b511
@adamdbradley
Copy link
Contributor

We can have the app's Sass included from the root app component instead of having another property on the config. ionic-team/ionic-framework#8307 (comment)

@jgw96 jgw96 deleted the feature/scssGlobalFix branch October 6, 2016 17:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mhartington @ramonornela @adamdbradley