The ionic-cli is not saving the variables to package.json on plugin add

[maksymilian-majer]

Plugin variables aren't being saved to the package.json after running ionic plugin add submodules/phonegap-facebook-plugin --variable APP_ID=SOMEID --variable APP_NAME=someName.

I checked the source of State in ionic-app-lib and it takes a variables arguments (source), but the ionic-cli does not pass it along (source).

[jbavari]

Nice catch. I'll patch it today. Thanks for reporting!

[jbavari]

@maksymilian-majer Mind double checking for me - npm install -g ionic@beta

The beta version should be passing along variables now.

[maksymilian-majer]

@jbavari I checked it and it works as expected 👍

[jbavari]

Awesome. I'll merge this into master and be pushing it out later. Thanks again for reporting!

[maksymilian-majer]

No problem. You're doing amazing work with ionic, glad to be helpful!

[yankustefan]

I ran into the same issue. I'm using CLI 1.5.5

ionic plugin add cc.fovea.cordova.purchase --variable BILLING_KEY="SOME_BILLING_KEY"

[eroh92]

Ran into this issue today using CLI 1.5.5 as well when I tried:

ionic plugin add https://github.com/Telerik-Verified-Plugins/Stripe --variable API_KEY=STRIPE_SECRET_API_KEY

[eroh92]

Note, I'm assuming that this thread is reporting that when you use the --variable flag, the variable doesn't get saved to the root package.json so you can use ionic state restore on other team's machines, build boxes, etc.

I tried npm install -g ionic@beta and it didn't work there either.

[kfatehi]

in my experience trying to use this with the facebook plugin i discovered that ionic add does edit the package.json correctly, however a restore or even a reset does not install the plugin correctly. the facebook plugin directly actually becomes completely empty. i did use the http url. for now I am installing the plugin via bash script immediately after ionic restore

[eroh92]

The facebook plugin is an exception as you need to have a copy of it
locally in order for it to install:
https://github.com/Wizcorp/phonegap-facebook-plugin#-----cordova-registry-warning-ios

On Thu, Jul 9, 2015 at 12:14 AM, Keyvan Fatehi notifications@github.com
wrote:

in my experience trying to use this with the facebook plugin
https://github.com/Wizcorp/phonegap-facebook-plugin i discovered that ionic
add does edit the package.json correctly, however a restore or even a
reset does not install the plugin correctly. the facebook plugin directly
actually becomes completely empty. i did use the http url. for now I am
installing the plugin via bash script immediately after ionic restore

—
Reply to this email directly or view it on GitHub
#429 (comment).

[kfatehi]

i would argue that because the locator attribute is set to a git repository, it is expected that under the hood ionic would locally clone the repo down and try to add it, thereby complying with that warning.