Skip to content

Commit

Permalink
feat(config): expose getMode() and deprecate Config (#19104)
Browse files Browse the repository at this point in the history
  • Loading branch information
manucorporat authored Sep 25, 2019
1 parent bfa17d1 commit 0f05ea4
Show file tree
Hide file tree
Showing 2 changed files with 15 additions and 1 deletion.
3 changes: 2 additions & 1 deletion angular/src/providers/config.ts
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@ export class Config {
}

set(key: keyof IonicConfig, value?: any) {
console.warn(`[DEPRECATION][Config]: The Config.set() method is deprecated and will be removed in the next major release.`);
const c = getConfig();
if (c) {
c.set(key, value);
Expand All @@ -44,7 +45,7 @@ export const ConfigToken = new InjectionToken<any>('USERCONFIG');

const getConfig = (): CoreConfig | null => {
if (typeof (window as any) !== 'undefined') {
const Ionic = (window as IonicWindow).Ionic;
const Ionic = (window as any as IonicWindow).Ionic;
if (Ionic && Ionic.config) {
return Ionic.config;
}
Expand Down
13 changes: 13 additions & 0 deletions core/src/utils/config.ts
Original file line number Diff line number Diff line change
Expand Up @@ -199,3 +199,16 @@ export const setupConfig = (config: IonicConfig) => {
};
return win.Ionic.config;
};

export const getMode = (): Mode => {
const win = window as any;
const config = win && win.Ionic && win.Ionic.config;
if (config) {
if (config.mode) {
return config.mode;
} else {
return config.get('mode');
}
}
return 'md';
};

0 comments on commit 0f05ea4

Please sign in to comment.