Skip to content

Commit 55bc32d

Browse files
committed
fix(popover): remove min-height from ios, add sass variables
sass variables added for min-width and min-height. closes #7215
1 parent d123464 commit 55bc32d

File tree

6 files changed

+15
-10
lines changed

6 files changed

+15
-10
lines changed

src/components.core.scss

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,6 @@
2222
"components/loading/loading",
2323
"components/menu/menu",
2424
"components/modal/modal",
25-
"components/popover/popover",
2625
"components/range/range",
2726
"components/refresher/refresher",
2827
"components/scroll/scroll",

src/components/popover/popover.ios.scss

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,12 @@
11
@import "../../globals.core";
2+
@import "./popover";
23

34
// iOS Popover
45
// --------------------------------------------------
56

67
$popover-ios-width: 200px !default;
8+
$popover-ios-min-width: 0 !default;
9+
$popover-ios-min-height: 0 !default;
710
$popover-ios-max-height: 90% !default;
811

912
$popover-ios-border-radius: 10px !default;
@@ -16,7 +19,8 @@ $popover-ios-arrow-background: $popover-ios-background !default;
1619

1720
.popover-content {
1821
width: $popover-ios-width;
19-
22+
min-width: $popover-ios-min-width;
23+
min-height: $popover-ios-min-height;
2024
max-height: $popover-ios-max-height;
2125

2226
border-radius: $popover-ios-border-radius;

src/components/popover/popover.md.scss

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,12 @@
11
@import "../../globals.core";
2+
@import "./popover";
23

34
// Material Design Popover
45
// --------------------------------------------------
56

67
$popover-md-width: 250px !default;
8+
$popover-md-min-width: 0 !default;
9+
$popover-md-min-height: 0 !default;
710
$popover-md-max-height: 90% !default;
811

912
$popover-md-border-radius: 2px !default;
@@ -17,8 +20,8 @@ $popover-md-item-background: $popover-md-background !default;
1720

1821
.popover-content {
1922
width: $popover-md-width;
20-
min-width: 0;
21-
min-height: 0;
23+
min-width: $popover-md-min-width;
24+
min-height: $popover-md-min-height;
2225
max-height: $popover-md-max-height;
2326

2427
border-radius: $popover-md-border-radius;

src/components/popover/popover.scss

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -34,8 +34,6 @@ ion-popover {
3434

3535
flex-direction: column;
3636

37-
min-height: 200px;
38-
3937
scroll-content {
4038
position: relative;
4139
}

src/components/popover/popover.wp.scss

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,12 @@
11
@import "../../globals.core";
2+
@import "./popover";
23

34
// Windows Popover
45
// --------------------------------------------------
56

67
$popover-wp-width: 200px !default;
8+
$popover-wp-min-width: 0 !default;
9+
$popover-wp-min-height: 0 !default;
710
$popover-wp-max-height: 90% !default;
811

912
$popover-wp-border: 2px solid #ccc !default;
@@ -16,8 +19,8 @@ $popover-wp-item-background: $popover-wp-background !default;
1619

1720
.popover-content {
1821
width: $popover-wp-width;
19-
min-width: 0;
20-
min-height: 0;
22+
min-width: $popover-wp-min-width;
23+
min-height: $popover-wp-min-height;
2124
max-height: $popover-wp-max-height;
2225

2326
border: $popover-wp-border;

src/components/popover/test/basic/index.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -139,8 +139,6 @@ class PopoverRadioPage {
139139
<ion-list-header>Ionic</ion-list-header>
140140
<button ion-item (click)="close()">Learn Ionic</button>
141141
<button ion-item (click)="close()">Documentation</button>
142-
<button ion-item (click)="close()">Showcase</button>
143-
<button ion-item (click)="close()">GitHub Repo</button>
144142
</ion-list>
145143
`
146144
})

0 commit comments

Comments
 (0)