Skip to content

Commit 5f2e737

Browse files
committed
feat(sass): add support for contrast in color map for wp mode
BREAKING CHANGE: Can now pass contrast to the colors map: ``` $colors-wp: ( primary: ( base: #327eff, contrast: yellow ), secondary: ( base: #32db64, contrast: hotpink ), danger: #d91e18, light: #f4f4f4, dark: #222 ) !default; ``` references #5445
1 parent 9efa3ea commit 5f2e737

File tree

17 files changed

+109
-107
lines changed

17 files changed

+109
-107
lines changed

ionic/components/alert/alert.wp.scss

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ $alert-wp-width: 100% !default;
1010
$alert-wp-max-width: 520px !default;
1111
$alert-wp-border-width: 1px !default;
1212
$alert-wp-border-style: solid !default;
13-
$alert-wp-border-color: map-get($colors-wp, primary) !default;
13+
$alert-wp-border-color: color($colors-wp, primary) !default;
1414
$alert-wp-border-radius: 0 !default;
1515
$alert-wp-background: #e6e6e6 !default;
1616

@@ -34,7 +34,7 @@ $alert-wp-input-padding: 0 8px !default;
3434
$alert-wp-input-border-width: 2px !default;
3535
$alert-wp-input-border-style: $alert-wp-border-style !default;
3636
$alert-wp-input-border-color: $input-wp-border-color !default;
37-
$alert-wp-input-border-color-focused: map-get($colors-wp, primary) !default;
37+
$alert-wp-input-border-color-focused: color($colors-wp, primary) !default;
3838
$alert-wp-input-line-height: 3rem !default;
3939
$alert-wp-input-text-color: #000 !default;
4040

@@ -54,7 +54,7 @@ $alert-wp-button-group-flex-wrap: wrap-reverse !default;
5454
$alert-wp-button-group-vertical-width: 100% !default;
5555
$alert-wp-button-group-vertical-margin-top: 5px !default;
5656

57-
$alert-wp-radio-background: map-get($colors-wp, primary) !default;
57+
$alert-wp-radio-background: color($colors-wp, primary) !default;
5858
$alert-wp-radio-border-color: $input-wp-border-color !default;
5959

6060
$alert-wp-radio-label-padding: 13px 26px !default;
@@ -85,15 +85,15 @@ $alert-wp-checkbox-border-style: solid !default;
8585
$alert-wp-checkbox-border-radius: 0 !default;
8686
$alert-wp-checkbox-border-color: $input-wp-border-color !default;
8787
$alert-wp-checkbox-background-off: transparent !default;
88-
$alert-wp-checkbox-background-on: map-get($colors-wp, primary) !default;
88+
$alert-wp-checkbox-background-on: color($colors-wp, primary) !default;
8989

9090
$alert-wp-checkbox-icon-top: -2px !default;
9191
$alert-wp-checkbox-icon-left: 3px !default;
9292
$alert-wp-checkbox-icon-width: 6px !default;
9393
$alert-wp-checkbox-icon-height: 12px !default;
9494
$alert-wp-checkbox-icon-border-width: 1px !default;
9595
$alert-wp-checkbox-icon-border-style: solid !default;
96-
$alert-wp-checkbox-icon-border-color: $alert-wp-background !default;
96+
$alert-wp-checkbox-icon-border-color: color-contrast($colors-wp, $alert-wp-checkbox-background-on) !default;
9797
$alert-wp-checkbox-icon-transform: rotate(45deg) !default;
9898

9999

ionic/components/app/app.wp.scss

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ hr {
1919
background-color: rgba(0, 0, 0, .08);
2020
}
2121

22-
@each $color-name, $color-value in $colors-wp {
22+
@each $color-name, $color-base, $color-contrast in get-colors($colors-wp) {
2323
h1,
2424
h2,
2525
h3,
@@ -38,7 +38,7 @@ hr {
3838
sup,
3939
ion-icon {
4040
&[#{$color-name}] {
41-
color: $color-value;
41+
color: $color-base;
4242
}
4343
}
4444
}

ionic/components/badge/badge.wp.scss

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -4,24 +4,25 @@
44
// --------------------------------------------------
55

66
$badge-wp-border-radius: 0 !default;
7-
$badge-wp-background-color: map-get($colors-wp, primary) !default;
7+
$badge-wp-background-color: color($colors-wp, primary) !default;
8+
$badge-wp-text-color: color-contrast($colors-wp, $badge-wp-background-color) !default;
89

910

1011
ion-badge {
1112
border-radius: $badge-wp-border-radius;
12-
color: color-inverse($badge-wp-background-color);
13+
color: $badge-wp-text-color;
1314
background-color: $badge-wp-background-color;
1415
}
1516

1617

1718
// Generate Windows Badge Colors
1819
// --------------------------------------------------
1920

20-
@each $color-name, $color-value in $colors-wp {
21+
@each $color-name, $color-base, $color-contrast in get-colors($colors-wp) {
2122

2223
.badge-#{$color-name} {
23-
color: color-inverse($color-value);
24-
background-color: $color-value;
24+
color: $color-contrast;
25+
background-color: $color-base;
2526
}
2627

2728
}

ionic/components/button/button.wp.scss

Lines changed: 13 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -13,9 +13,9 @@ $button-wp-border-width: 3px !default;
1313
$button-wp-border-radius: 0 !default;
1414

1515
// Regular button
16-
$button-wp-background-color: map-get($colors-wp, primary) !default;
16+
$button-wp-background-color: color($colors-wp, primary) !default;
1717
$button-wp-background-color-activated: color-shade($button-wp-background-color) !default;
18-
$button-wp-text-color: color-inverse($button-wp-background-color) !default;
18+
$button-wp-text-color: color-contrast($colors-wp, $button-wp-background-color) !default;
1919

2020
// Clear button
2121
$button-wp-clear-background-color-hover: rgba(158, 158, 158, .1) !default;
@@ -76,12 +76,12 @@ $button-wp-fab-border-radius: 50% !default;
7676
// Windows Default Button Color Mixin
7777
// --------------------------------------------------
7878

79-
@mixin wp-button-default($color-name, $color-value) {
79+
@mixin wp-button-default($color-name, $color-base, $color-contrast) {
8080

8181
.button-#{$color-name} {
82-
$bg-color: $color-value;
82+
$bg-color: $color-base;
8383
$bg-color-activated: color-shade($bg-color);
84-
$fg-color: color-inverse($bg-color);
84+
$fg-color: $color-contrast;
8585

8686
color: $fg-color;
8787
background-color: $bg-color;
@@ -165,10 +165,10 @@ $button-wp-fab-border-radius: 50% !default;
165165
// Windows Outline Button Color Mixin
166166
// --------------------------------------------------
167167

168-
@mixin wp-button-outline($color-name, $color-value) {
168+
@mixin wp-button-outline($color-name, $color-base, $color-contrast) {
169169

170170
.button-outline-#{$color-name} {
171-
$fg-color: color-shade($color-value, 5%);
171+
$fg-color: color-shade($color-base, 5%);
172172
border-color: $fg-color;
173173
color: $fg-color;
174174

@@ -205,10 +205,10 @@ $button-wp-fab-border-radius: 50% !default;
205205
// Windows Clear Button Color Mixin
206206
// --------------------------------------------------
207207

208-
@mixin wp-button-clear($color-name, $color-value) {
208+
@mixin wp-button-clear($color-name, $color-base, $color-contrast) {
209209

210210
.button-clear-#{$color-name} {
211-
$fg-color: $color-value;
211+
$fg-color: $color-base;
212212
color: $fg-color;
213213

214214
&.activated {
@@ -251,10 +251,10 @@ ion-button-effect {
251251
// Generate Windows Button Colors
252252
// --------------------------------------------------
253253

254-
@each $color-name, $color-value in $colors-wp {
255-
@include wp-button-default($color-name, $color-value);
256-
@include wp-button-outline($color-name, $color-value);
257-
@include wp-button-clear($color-name, $color-value);
254+
@each $color-name, $color-base, $color-contrast in get-colors($colors-wp) {
255+
@include wp-button-default($color-name, $color-base, $color-contrast);
256+
@include wp-button-outline($color-name, $color-base, $color-contrast);
257+
@include wp-button-clear($color-name, $color-base, $color-contrast);
258258
}
259259

260260

ionic/components/checkbox/checkbox.wp.scss

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -12,18 +12,18 @@ $checkbox-wp-media-margin: $item-wp-padding-media-top $item-wp-pad
1212
$checkbox-wp-disabled-opacity: .3 !default;
1313

1414
$checkbox-wp-icon-background-color-off: $list-wp-background-color !default;
15-
$checkbox-wp-icon-background-color-on: map-get($colors-wp, primary) !default;
15+
$checkbox-wp-icon-background-color-on: color($colors-wp, primary) !default;
1616
$checkbox-wp-icon-size: 16px !default;
1717

1818
$checkbox-wp-icon-checkmark-width: 1px !default;
1919
$checkbox-wp-icon-checkmark-style: solid !default;
20-
$checkbox-wp-icon-checkmark-color: $background-wp-color !default;
20+
$checkbox-wp-icon-checkmark-color: color-contrast($colors-wp, $checkbox-wp-icon-background-color-on) !default;
2121

2222
$checkbox-wp-icon-border-width: 2px !default;
2323
$checkbox-wp-icon-border-style: solid !default;
2424
$checkbox-wp-icon-border-radius: 0 !default;
2525
$checkbox-wp-icon-border-color-off: #333 !default;
26-
$checkbox-wp-icon-border-color-on: map-get($colors-wp, primary) !default;
26+
$checkbox-wp-icon-border-color-on: color($colors-wp, primary) !default;
2727

2828

2929
ion-checkbox {
@@ -107,14 +107,14 @@ ion-checkbox + .item-inner ion-label {
107107
// Windows Checkbox Color Mixin
108108
// --------------------------------------------------
109109

110-
@mixin checkbox-theme-wp($color-name, $bg-on) {
110+
@mixin checkbox-theme-wp($color-name, $color-base, $color-contrast) {
111111

112112
ion-checkbox[#{$color-name}] .checkbox-checked {
113-
border-color: $bg-on;
114-
background-color: $bg-on;
113+
border-color: $color-base;
114+
background-color: $color-base;
115115

116116
.checkbox-inner {
117-
border-color: color-inverse($bg-on);
117+
border-color: $color-contrast;
118118
}
119119
}
120120

@@ -124,6 +124,6 @@ ion-checkbox + .item-inner ion-label {
124124
// Generate Windows Checkbox Colors
125125
// --------------------------------------------------
126126

127-
@each $color-name, $color-value in $colors-wp {
128-
@include checkbox-theme-wp($color-name, $color-value);
127+
@each $color-name, $color-base, $color-contrast in get-colors($colors-wp) {
128+
@include checkbox-theme-wp($color-name, $color-base, $color-contrast);
129129
}

ionic/components/chip/chip.wp.scss

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,12 +7,12 @@
77
// Generate Windows Chip Colors
88
// --------------------------------------------------
99

10-
@each $color-name, $color-value in $colors-wp {
10+
@each $color-name, $color-base, $color-contrast in get-colors($colors-wp) {
1111

1212
ion-chip {
1313
ion-icon[#{$color-name}] {
14-
color: color-inverse($color-value);
15-
background-color: $color-value;
14+
color: $color-contrast;
15+
background-color: $color-base;
1616
}
1717
}
1818

ionic/components/input/input.wp.scss

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -16,9 +16,9 @@ $text-input-wp-padding-vertical: 0 !default;
1616
$text-input-wp-padding-horizontal: 8px !default;
1717
$text-input-wp-line-height: 3rem !default;
1818

19-
$text-input-wp-highlight-color: map-get($colors-wp, primary) !default;
20-
$text-input-wp-hightlight-color-valid: map-get($colors-wp, secondary) !default;
21-
$text-input-wp-hightlight-color-invalid: map-get($colors-wp, danger) !default;
19+
$text-input-wp-highlight-color: color($colors-wp, primary) !default;
20+
$text-input-wp-hightlight-color-valid: color($colors-wp, secondary) !default;
21+
$text-input-wp-hightlight-color-invalid: color($colors-wp, danger) !default;
2222

2323
$text-input-wp-input-clear-icon-width: 30px !default;
2424
$text-input-wp-input-clear-icon-color: $input-wp-border-color !default;

ionic/components/item/item.wp.scss

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -174,10 +174,10 @@ ion-item-divider {
174174
// Generate Windows Item Divider Colors
175175
// --------------------------------------------------
176176

177-
@each $color-name, $color-value in $colors-wp {
177+
@each $color-name, $color-base, $color-contrast in get-colors($colors-wp) {
178178
ion-item-divider[#{$color-name}] {
179-
color: color-inverse($color-value);
180-
background-color: $color-value;
179+
color: $color-contrast;
180+
background-color: $color-base;
181181
}
182182
}
183183

ionic/components/label/label.wp.scss

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
// --------------------------------------------------
66

77
$label-wp-text-color: #999 !default;
8-
$label-wp-text-color-focused: map-get($colors-wp, primary) !default;
8+
$label-wp-text-color-focused: color($colors-wp, primary) !default;
99

1010

1111
// Windows Default Label
@@ -63,10 +63,10 @@ ion-label[floating] {
6363
// Generate Windows Label colors
6464
// --------------------------------------------------
6565

66-
@each $color-name, $color-value in $colors-wp {
66+
@each $color-name, $color-base, $color-contrast in get-colors($colors-wp) {
6767

6868
ion-label[#{$color-name}] {
69-
color: $color-value;
69+
color: $color-base;
7070
}
7171

7272
}

ionic/components/radio/radio.wp.scss

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
// Windows Radio
44
// --------------------------------------------------
55

6-
$radio-wp-color-on: map-get($colors-wp, primary) !default;
6+
$radio-wp-color-on: color($colors-wp, primary) !default;
77
$radio-wp-color-off: #333 !default;
88

99
// Places radio icon on the left of the item
@@ -110,12 +110,12 @@ ion-radio {
110110
// Windows Radio Color Mixin
111111
// --------------------------------------------------
112112

113-
@mixin radio-theme-wp($color-name, $color-value) {
113+
@mixin radio-theme-wp($color-name, $color-base) {
114114

115115
ion-radio[#{$color-name}] {
116116

117117
.radio-checked {
118-
border-color: $color-value;
118+
border-color: $color-base;
119119
}
120120

121121
}
@@ -126,8 +126,8 @@ ion-radio {
126126
// Generate Windows Radio Colors
127127
// --------------------------------------------------
128128

129-
@each $color-name, $color-value in $colors-wp {
129+
@each $color-name, $color-base, $color-contrast in get-colors($colors-wp) {
130130

131-
@include radio-theme-wp($color-name, $color-value);
131+
@include radio-theme-wp($color-name, $color-base);
132132

133133
}

0 commit comments

Comments
 (0)