Skip to content

fix(datetime): calendar day and years are now localized #25847

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Sep 1, 2022
Merged

Conversation

liamdebeasi
Copy link
Contributor

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
    • Some docs updates need to be made in the ionic-docs repo, in a separate PR. See the contributing guide for details.
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue URL: resolves #25843

What is the new behavior?

  • The day buttons in the calendar grid are now localized. Previously they always used a Latin script. Note: Some languages add literals to the end of the day string (Example: 29日 in Japanese). These literals have been removed to align with how native iOS and Android localize the day buttons.
  • The year buttons in the year wheel column are now localized. Previously they always used a Latin script. Note: Some languages add literals to the end of the year string. These literals have not been removed to align with how native iOS and Android localize the year string.

Does this introduce a breaking change?

  • Yes
  • No

Other information

@github-actions github-actions bot added the package: core @ionic/core package label Aug 29, 2022
@liamdebeasi liamdebeasi marked this pull request as ready for review August 29, 2022 16:31
@liamdebeasi liamdebeasi requested a review from a team August 29, 2022 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: core @ionic/core package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: datetime, days of month are not localized according to numbering system
3 participants