Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: ion-datetime date and time pickers do not render correctly on (some) devices with maximum font size set #25964

Open
5 of 7 tasks
ppolce opened this issue Sep 18, 2022 · 12 comments
Labels
package: core @ionic/core package type: bug a confirmed bug report

Comments

@ppolce
Copy link

ppolce commented Sep 18, 2022

Prerequisites

Ionic Framework Version

  • v4.x
  • v5.x
  • v6.x
  • Nightly

Current Behavior

Date and Time pickers do not render correctly on Samsung Galaxy S21 when the font size is set to largest.
Labels overlap and make the text unreadable.

NOTE: It only seem to affect some android phones (e.g. Galaxy S21).

Expected Behavior

Rows should not overlap. Text should be visible at any font size setting.

Steps to Reproduce

  1. ionic start choose Angular / Tabs application
  2. edit tab1.page.html, comment out (or remove) the <app-explorer-container> line
  3. add <ion-datetime></ion-datetime>
  4. add android npm i @capacitor/android
  5. build a testapp.apk
  6. Install the apk on an android device that allows for very large fonts (in my case, Samsung Galaxy S21).
  7. Open settings and choose the largest font size available

Run the app. A page with the current month's calendar appears.
Click on the date picker, you’ll see that the months overlap:

image

and

image

Code Reproduction URL

No response

Ionic Info


Ionic:

   Ionic CLI                     : 6.20.1 (/home/develop/.local/lib/node_modules/@ionic/cli)
   Ionic Framework               : @ionic/angular 5.9.4
   @angular-devkit/build-angular : 13.3.9
   @angular-devkit/schematics    : 13.3.9
   @angular/cli                  : 13.3.9
   @ionic/angular-toolkit        : 6.1.0

Capacitor:

   Capacitor CLI      : 4.2.0
   @capacitor/android : 4.2.0
   @capacitor/core    : 4.2.0
   @capacitor/ios     : 4.2.0

Utility:

   cordova-res : not installed globally
   native-run  : 1.7.0

System:

   NodeJS : v14.20.0 (/usr/bin/node)
   npm    : 7.24.2
   OS     : Linux 5.15

Additional Information

same as reported here: https://forum.ionicframework.com/t/ion-datetime-date-and-time-pickers-do-not-render-correctly-on-devices-with-high-accessibility-settings/225750

@ionitron-bot ionitron-bot bot added the triage label Sep 18, 2022
@liamdebeasi liamdebeasi self-assigned this Sep 19, 2022
@liamdebeasi liamdebeasi added the ionitron: needs reproduction a code reproduction is needed from the issue author label Sep 19, 2022
@ionitron-bot
Copy link

ionitron-bot bot commented Sep 19, 2022

Thanks for the issue! This issue has been labeled as needs reproduction. This label is added to issues that need a code reproduction.

Please reproduce this issue in an Ionic starter application and provide a way for us to access it (GitHub repo, StackBlitz, etc). Without a reliable code reproduction, it is unlikely we will be able to resolve the issue, leading to it being closed.

If you have already provided a code snippet and are seeing this message, it is likely that the code snippet was not enough for our team to reproduce the issue.

For a guide on how to create a good reproduction, see our Contributing Guide.

@ionitron-bot ionitron-bot bot removed the triage label Sep 19, 2022
@liamdebeasi liamdebeasi removed their assignment Sep 19, 2022
@ppolce
Copy link
Author

ppolce commented Sep 19, 2022

Hi @liamdebeasi,

I have created a little app that's just the ionic "blank app" with a ion-datetime component on the homepage.
You can find it here: https://github.com/ppolce/ion-datetime-bug

Thanks a lot for your help!
P

@liamdebeasi liamdebeasi added package: core @ionic/core package type: bug a confirmed bug report and removed ionitron: needs reproduction a code reproduction is needed from the issue author labels Sep 19, 2022
@liamdebeasi
Copy link
Contributor

Here is a dev build with a proposed fix if you are interested in testing it:

npm install @ionic/angular@6.2.8-dev.11664221659.1dd1c3b9

@ppolce
Copy link
Author

ppolce commented Sep 27, 2022

Hi,

Tested it. It works as expected.
Thanks a lot!
P

@Pablito203
Copy link

Hi @liamdebeasi,

Will this fix be merged into newer versions?

@luqasmateus
Copy link

Hello @liamdebeasi

I can't update my apps to the latest @ionic/angular version because of this bug. Can you take a look at this again, please?
The dev build you provided works correctly.

@Sampath-Lokuge
Copy link

Any reason why this has not been merged yet?

@liamdebeasi
Copy link
Contributor

The proposed patch regressed selection behavior, so we are unable to merge the fix in its current state. We'll need to investigate an alternative fix in the future.

@Sampath-Lokuge
Copy link

Sampath-Lokuge commented Apr 21, 2023

Hmm...

Do you know how to solve this issue then? i.e. I cannot see full dates here. Thanks!

This didn't help me:

<ion-popover
     trigger="end-date-picker"
     show-backdrop="false"
     side="top"
     alignment="start"
   >

calender

@liamdebeasi
Copy link
Contributor

liamdebeasi commented Apr 21, 2023

See #24780 This is a known bug.

@Sampath-Lokuge
Copy link

Yes, it is disappointing. If you can provide the CSS changes like paddings and etc within calendar dates then we can acquire more vertical spaces within the calendar. Now it has a lot of paddings in between date rows. But we cannot change that due to the shadow dom effect.

@DevForAll-Loic
Copy link

The proposed patch regressed selection behavior, so we are unable to merge the fix in its current state. We'll need to investigate an alternative fix in the future.

Hey, my company is asking if there is any news ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: core @ionic/core package type: bug a confirmed bug report
Projects
None yet
6 participants