-
Notifications
You must be signed in to change notification settings - Fork 13.4k
fix(toggle): rtl layout renders correctly in safari #26315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I had some comments on this over in #26314, but we can handle discussion there 👀 |
Great catch! I fixed this in d52eec6. |
@amandaejohnston I updated the screenshots. I'm going hold off on updating #26314 until this PR gets merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like LTR was affected now; looking at core/src/components/toggle/test/enable-on-off-labels/toggle.e2e.ts-snapshots/toggle-on-off-labels-dark-mode-diff-ios-ltr-Mobile-Safari-linux.png
for example, the "O" for unchecked toggles is missing, and the "I" for checked ones is off-center.
The problem was I kept targeting |
Pull request checklist
Please check if your PR fulfills the following requirements:
ionic-docs
repo, in a separate PR. See the contributing guide for details.npm run build
) was run locally and any changes were pushednpm run lint
) has passed locally and any fixes were made for failuresPull request type
Please check the type of change your PR introduces:
What is the current behavior?
Issue URL: Part of #17012
While working on #26314 I noticed this was still a problem. I fixed the problem in the v7 branch but wanted to pull this out to get this into v6.
What is the new behavior?
Does this introduce a breaking change?
Other information