fix(input): clear button uses contrast when setting color on item #26592
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
Please check if your PR fulfills the following requirements:
ionic-docs
repo, in a separate PR. See the contributing guide for details.npm run build
) was run locally and any changes were pushednpm run lint
) has passed locally and any fixes were made for failuresPull request type
Please check the type of change your PR introduces:
What is the current behavior?
Issue URL: resolves #26337
The input inherits contrast color from the
ion-item
when the item has thecolor
property set. However, the clear icon remains a dark gray. This means that the clear button often does not have the correct contrast on the item background.What is the new behavior?
color
is set onion-item
.Note: I chose this architecture to avoid a global css style like
ion-item.ion-color ion-input .input-clear-icon
. I could not target this within theion-item
stylesheets because::slotted
only targets elements that have been placed into a slot.Does this introduce a breaking change?
I originally thought making the initial change was a breaking change, but it wasn’t. If developers were targeting ion-icon to change the color, that css will still work as it requires a more specific selector than .input-clear-icon already.
Other information