Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(datetime): allow header to render in all wheel picker presentations #26616

Merged
merged 4 commits into from Jan 17, 2023

Conversation

amandaejohnston
Copy link
Contributor

@amandaejohnston amandaejohnston commented Jan 17, 2023

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
    • Some docs updates need to be made in the ionic-docs repo, in a separate PR. See the contributing guide for details.
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Presentations time, month, month-year, and year do not currently render the header, even if showDefaultTitle is set to true or something is provided in the title slot. While the original intention may have been to avoid showing the header for wheel pickers, it is currently possible to enable this in other presentations using the preferWheel property.

Issue URL: Resolves #26600

What is the new behavior?

The header now renders in those presentations if enabled. Note that the currently selected date is not shown, since these presentations don't involve selecting specific date(s).

Does this introduce a breaking change?

  • Yes
  • No

Other information

@stackblitz
Copy link

stackblitz bot commented Jan 17, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@github-actions github-actions bot added the package: core @ionic/core package label Jan 17, 2023
@amandaejohnston amandaejohnston changed the title fix(datetime): render header in all wheel picker views fix(datetime): allow header to render in all wheel picker presentations Jan 17, 2023
@amandaejohnston amandaejohnston marked this pull request as ready for review January 17, 2023 20:19
Copy link
Member

@liamdebeasi liamdebeasi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good. We may want to rename renderCalendarViewHeader since it's no longer specific to the calendar layout. Maybe renderHeader would do? We already have a renderFooter method.

Copy link
Contributor

@sean-perkins sean-perkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ditto on the rename for the render function. Nice work here!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: core @ionic/core package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: ion-datetime title is not displayed when presentation="month-year"
4 participants