fix(select): adjust label alignment when in a card #27202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
liamdebeasi
requested changes
Apr 14, 2023
| await page.setContent(` | ||
| <ion-card> | ||
| <ion-card-content> | ||
| <ion-item style="border: 1px solid grey; margin: 16px"> |
There was a problem hiding this comment.
Is the border for a visual reference for the label alignment? If so, what is the margin: 16px for?
~ Nit: Can we add lines="none" to the ion-item if we are going to draw a border around the container? Currently there are two bottom border lines.
liamdebeasi
approved these changes
Apr 20, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue URL: resolves #27086
What is the current behavior?
When an
ion-selectis inside a card, the label is slightly lower than it should be, making it out of alignment with the label of anion-input.What is the new behavior?
ion-inputandion-selectare in line with each other.Does this introduce a breaking change?
Other information
This bug was occurring because the label of ion-select is in the shadow DOM. As recommended, this fix was also added to ion-input and ion-textarea in case those labels are also later moved to the shadow DOM.
Before:
After:
