refactor(item): remove deprecated apis #29102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
package: core
liamdebeasi
requested review from
brandyscarney,
thetaPC,
sean-perkins and
a team
as code owners
averyjohnston
suggested changes
Mar 6, 2024
Co-authored-by: Amanda Johnston <90629384+amandaejohnston@users.noreply.github.com>
mapsandapps
suggested changes
Mar 6, 2024
There was a problem hiding this comment.
I think I found two other things that can be removed:
- The
item-md-input-counter-letter-spacingvariable in item.md.vars.scss - The
.item-bottomstyles in item.scss
averyjohnston
approved these changes
Mar 6, 2024
mapsandapps
approved these changes
Mar 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: Internal
What is the current behavior?
Item the following deprecated APIs:
Props
Slots
What is the new behavior?
Does this introduce a breaking change?
Other information
BREAKING CHANGE:
helperslot has been removed. Developers should use thehelperTextproperty onion-inputandion-textarea.errorslot has been removed. Developers should use theerrorTextproperty onion-inputandion-textarea.counterandcounterFormatterproperties. Developers should use the properties of the same name onion-inputandion-textarea.fillproperty has been removed. Developers should use the property of the same name onion-input,ion-select, andion-textarea.shapeproperty has been removed. Developers should use the property of the same name onion-input,ion-select, andion-textarea.