fix(select): options are visible with fit-content width and fill outline #29408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
sean-perkins
commented
Apr 26, 2024
| @@ -2,7 +2,11 @@ | |||
| @import "./select-popover.md.vars"; | |||
|
|
|||
| ion-list ion-radio::part(container) { | |||
| opacity: 0; | |||
There was a problem hiding this comment.
Looks like this fixes another issue we never caught where the label text did not extend the full width of the row (because the radio container was still taking up space)
| Before | After |
|---|---|
 |
 |
liamdebeasi
approved these changes
Apr 29, 2024
|
Tested it out, and it works well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: resolves #29321
What is the current behavior?
When using a select with
fill="outline",interface="popover"and a width that fits the content of the options, the select options are not visible. The hidden radio is covering the text of the radio text options.What is the new behavior?
Does this introduce a breaking change?
Other information
Dev-build:
8.0.2-dev.11714165638.13e7dd5bReproduction (issue): https://stackblitz.com/edit/angular-mndtkr
Reproduction (with dev-build): https://stackblitz.com/edit/angular-mndtkr-d7wsnp
Reproduction steps: