Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(avatar): add styles for xlarge size in ionic theme #29549

Merged
merged 10 commits into from
May 28, 2024
Merged

feat(avatar): add styles for xlarge size in ionic theme #29549

merged 10 commits into from
May 28, 2024

Conversation

brandyscarney
Copy link
Member

@brandyscarney brandyscarney commented May 23, 2024 •
edited

Issue number: internal

What is the current behavior?

Avatar does not have styles for the "xlarge" size in the ionic theme.

What is the new behavior?

  • Adds the styles for the xlarge size (width, height, padding, font size and line height)
  • Adds e2e test for xlarge size to the existing avatar test for sizes

Does this introduce a breaking change?

  • Yes
  • No

Other information

Preview

@vercel Vercel
Copy link

vercel bot commented May 23, 2024 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ionic-framework ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 28, 2024 3:25pm

@github-actions github-actions bot added the package: core @ionic/core package label May 23, 2024
@brandyscarney brandyscarney marked this pull request as ready for review May 23, 2024 18:43
@brandyscarney brandyscarney requested a review from a team as a code owner May 23, 2024 18:43
@brandyscarney brandyscarney mentioned this pull request May 23, 2024
Merged
2 tasks
Base automatically changed from ROU-10733 to next May 28, 2024 13:48
brandyscarney and others added 2 commits May 28, 2024 10:21
@brandyscarney @OS-giulianasilva
Update core/src/components/avatar/avatar.ionic.scss
f7a8856 
Co-authored-by: Giuliana Silva <108938618+OS-giulianasilva@users.noreply.github.com>
@brandyscarney
chore(): add updated snapshots
2c3f2f3
@brandyscarney brandyscarney merged commit 01c1b4f into next May 28, 2024
46 checks passed
@brandyscarney brandyscarney deleted the ROU-10737 branch May 28, 2024 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BenOsodrac BenOsodrac BenOsodrac approved these changes

@OS-giulianasilva OS-giulianasilva OS-giulianasilva approved these changes

Assignees
No one assigned
Labels
package: core @ionic/core package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@brandyscarney @BenOsodrac @OS-giulianasilva