This repository was archived by the owner on Apr 2, 2018. It is now read-only.
Adds support for windows platform #104
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/windows/KeyboardProxy.js
Outdated
There was a problem hiding this comment.
if (typeof inputPane.tryShow === 'function')
That will allow you to test for the function instead of testing the platform. Drop the 'isPhone' variable altogether.
|
Thanks for reviewing @robpaveza, I've taken your comments into account. |
|
@tlancina , @FelipeGualberto , ping ... |
|
Very nice! I think it's ok . @tlancina what do you think? |
|
Looks good to me, thanks for the PR! |
tlancina
added a commit
that referenced
this pull request
Jul 1, 2015
Adds support for windows platform
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for the windows platform.