Skip to content

Commit 09d69b9

Browse files
fix(list): do not style last child items by default (#16456)
fixes #15185
1 parent d09e555 commit 09d69b9

File tree

3 files changed

+27
-15
lines changed

3 files changed

+27
-15
lines changed

core/src/components/list/list.ios.scss

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -10,15 +10,6 @@
1010
background: $item-ios-background;
1111
}
1212

13-
.list-ios:not(.list-inset):not(.list-ios-lines-none) .item:last-child {
14-
--inner-border-width: 0;
15-
--border-width: #{0 0 $list-ios-item-border-bottom-width 0};
16-
}
17-
// .list-ios:not(.list-inset) + .list-ios:not(.list-inset) ion-list-header {
18-
// @include margin(-$list-ios-margin-top, null, null, null);
19-
// @include padding(0, null, null, null);
20-
// }
21-
2213

2314
// iOS Inset List
2415
// --------------------------------------------------

core/src/components/list/list.md.scss

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -15,11 +15,6 @@
1515
@include position-horizontal(0, null);
1616
}
1717

18-
.list-md:not(.list-inset):not(.list-md-lines-none) .item:last-child {
19-
--inner-border-width: 0;
20-
--border-width: #{0 0 $list-md-item-border-bottom-width 0};
21-
}
22-
2318

2419
// Material Design Inset List
2520
// --------------------------------------------------

core/src/components/list/test/lines/index.html

Lines changed: 27 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919
</ion-toolbar>
2020
</ion-header>
2121

22-
<ion-content >
22+
<ion-content>
2323
<ion-list lines="full">
2424
<ion-list-header>Lines: full</ion-list-header>
2525
<ion-item>Pokémon Yellow</ion-item>
@@ -54,6 +54,32 @@
5454
<ion-item>Final Fantasy VII</ion-item>
5555
</ion-list>
5656

57+
<ion-list>
58+
<ion-list-header>Wrapper item: default</ion-list-header>
59+
<div><ion-item>Pokémon Yellow</ion-item></div>
60+
<div><ion-item>Super Metroid</ion-item></div>
61+
<div><ion-item>Mega Man X</ion-item></div>
62+
<div><ion-item>The Legend of Zelda</ion-item></div>
63+
<div><ion-item>Pac-Man</ion-item></div>
64+
</ion-list>
65+
66+
<ion-list lines="none">
67+
<ion-list-header>Wrapper list lines: none</ion-list-header>
68+
<div><ion-item>Pokémon Yellow</ion-item></div>
69+
<div><ion-item>Super Metroid</ion-item></div>
70+
<div><ion-item>Mega Man X</ion-item></div>
71+
<div><ion-item>The Legend of Zelda</ion-item></div>
72+
<div><ion-item>Pac-Man</ion-item></div>
73+
</ion-list>
74+
75+
<ion-list>
76+
<ion-list-header>Wrapper w/ item lines: none</ion-list-header>
77+
<div><ion-item lines="none">Pokémon Yellow</ion-item></div>
78+
<div><ion-item lines="none">Super Metroid</ion-item></div>
79+
<div><ion-item lines="none">Mega Man X</ion-item></div>
80+
<div><ion-item lines="none">The Legend of Zelda</ion-item></div>
81+
<div><ion-item lines="none">Pac-Man</ion-item></div>
82+
</ion-list>
5783
</ion-content>
5884

5985
</ion-app>

0 commit comments

Comments
 (0)