Skip to content

Commit 158f717

Browse files
committed
fix(virtualScroll): fixes from rc1 breaking changes
1 parent 4c19d15 commit 158f717

File tree

6 files changed

+9
-11
lines changed

6 files changed

+9
-11
lines changed

ionic/components/virtual-scroll/test/basic/main.html

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,11 +13,11 @@
1313
<ion-list [virtualScroll]="items"
1414
[headerFn]="headerFn">
1515

16-
<ion-item-divider *virtualHeader="#header">
16+
<ion-item-divider *virtualHeader="let header">
1717
Header: {{header}}
1818
</ion-item-divider>
1919

20-
<ion-item *virtualItem="#item">
20+
<ion-item *virtualItem="let item">
2121
Item: {{item}}
2222
</ion-item>
2323

ionic/components/virtual-scroll/test/cards/main.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44

55
<div [virtualScroll]="items" approxItemHeight="320px">
66

7-
<ion-card *virtualItem="#item">
7+
<ion-card *virtualItem="let item">
88

99
<div>
1010
<ion-img [src]="item.imgSrc" [height]="item.imgHeight"></ion-img>

ionic/components/virtual-scroll/test/image-gallery/main.html

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -52,16 +52,16 @@
5252
approxHeaderWidth="100%"
5353
approxHeaderHeight="36px">
5454

55-
<div *virtualHeader="#header" class="virtual-header">
55+
<div *virtualHeader="let header" class="virtual-header">
5656
Header: {{header.date}}
5757
</div>
5858

59-
<div *virtualItem="#item" class="virtual-item">
59+
<div *virtualItem="let item" class="virtual-item">
6060
<ion-img [src]="item.imgSrc"></ion-img>
6161
<!--{{ item.index }}-->
6262
</div>
6363

64-
<div *virtualFooter="#footer" class="virtual-footer">
64+
<div *virtualFooter="let footer" class="virtual-footer">
6565
footer
6666
</div>
6767

ionic/components/virtual-scroll/test/variable-size/main.html

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,11 +4,11 @@
44

55
<ion-list [virtualScroll]="items" [headerFn]="headerFn">
66

7-
<ion-item-divider *virtualHeader="#header">
7+
<ion-item-divider *virtualHeader="let header">
88
Header: {{ header }}
99
</ion-item-divider>
1010

11-
<ion-item *virtualItem="#item">
11+
<ion-item *virtualItem="let item">
1212
<span [style.fontSize]="item.fontSize">{{ item.item }}</span>
1313
</ion-item>
1414

ionic/components/virtual-scroll/virtual-scroll.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -485,7 +485,7 @@ export class VirtualScroll implements DoCheck, AfterContentInit, OnDestroy {
485485
for (var i = 0; i < this._nodes.length; i++) {
486486
node = this._nodes[i];
487487
if (node.hasChanges) {
488-
node.view['changeDetectorRef'].detectChanges();
488+
node.view['detectChanges']();
489489
node.hasChanges = false;
490490
}
491491
}

ionic/components/virtual-scroll/virtual-util.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -239,8 +239,6 @@ export function populateNodeData(startCellIndex: number, endCellIndex: number, v
239239
// apply the cell's data to this node
240240
availableNode.view.context.$implicit = cell.data || records[cell.record];
241241
availableNode.view.context.index = cellIndex;
242-
availableNode.view.context.even = (cellIndex % 2 === 0);
243-
availableNode.view.context.odd = (cellIndex % 2 === 1);
244242
availableNode.hasChanges = true;
245243
availableNode.lastTransform = null;
246244
madeChanges = true;

0 commit comments

Comments
 (0)