Skip to content

Commit 4512c5c

Browse files
manucorporatadamdbradley
authored andcommitted
fix(item): tappable does not make ion-label pointer-event:none
1 parent 25e581a commit 4512c5c

File tree

3 files changed

+17
-3
lines changed

3 files changed

+17
-3
lines changed

src/components/item/test/buttons/app-module.ts

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,10 @@ export class E2EPage {
99
testClick(ev: any) {
1010
console.log('CLICK!', ev.target.tagName, ev.target.textContent.trim());
1111
}
12+
13+
testClickOutsize(ev: any) {
14+
console.log('CLICK OUTSIDE!', ev.target.tagName, ev.target.textContent.trim());
15+
}
1216
}
1317

1418
@Component({

src/components/item/test/buttons/main.html

Lines changed: 12 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@
3333
button[ion-item] danger
3434
</button>
3535

36-
<ion-item>
36+
<ion-item (click)="testClickOutsize($event)">
3737
<button ion-button item-left (click)="testClick($event)">Default</button>
3838
Inner Buttons
3939
<button ion-button outline item-right (click)="testClick($event)">Outline</button>
@@ -111,6 +111,17 @@ <h3>ng-for {{i}}</h3>
111111
<ion-badge item-right>260k</ion-badge>
112112
</button>
113113

114+
<ion-item (click)="testClickOutsize($event)">
115+
<div>
116+
<button ion-button icon-only clear item-right (click)="testClick($event)">
117+
<ion-icon name="remove-circle"></ion-icon>
118+
</button>
119+
<button ion-button icon-only clear item-right (click)="testClick($event)">
120+
<ion-icon name="add-circle"></ion-icon>
121+
</button>
122+
</div>
123+
</ion-item>
124+
114125
</ion-content>
115126

116127

src/themes/normalize.scss

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -156,8 +156,7 @@ textarea {
156156
}
157157

158158
a ion-label,
159-
button ion-label,
160-
[tappable] ion-label {
159+
button ion-label {
161160
pointer-events: none;
162161
}
163162

0 commit comments

Comments
 (0)