Skip to content

Commit 4c5dd0b

Browse files
committed
fix(radio): add styling for radio when item-left/item-right is added
references #5925
1 parent 5dddce3 commit 4c5dd0b

File tree

4 files changed

+40
-4
lines changed

4 files changed

+40
-4
lines changed

ionic/components/radio/radio.ios.scss

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,9 @@ $radio-ios-icon-border-style: solid !default;
1212

1313
$radio-ios-disabled-opacity: .3 !default;
1414

15+
$radio-ios-item-left-margin: 8px 21px 8px 3px !default;
16+
$radio-ios-item-right-margin: $item-ios-padding-media-top 11px $item-ios-padding-media-bottom ($item-ios-padding-left / 2) !default;
17+
1518

1619
ion-radio {
1720
position: relative;
@@ -69,7 +72,11 @@ ion-radio {
6972
position: static;
7073
display: block;
7174

72-
margin: $item-ios-padding-media-top ($item-ios-padding-right / 2) $item-ios-padding-media-bottom ($item-ios-padding-left / 2);
75+
margin: $radio-ios-item-right-margin;
76+
77+
&[item-left] {
78+
margin: $radio-ios-item-left-margin;
79+
}
7380
}
7481

7582
.item-radio ion-label {

ionic/components/radio/radio.md.scss

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,8 @@ $radio-md-transition-easing: cubic-bezier(.4, 0, .2, 1) !default;
1717

1818
$radio-md-disabled-opacity: .3 !default;
1919

20+
$radio-md-item-left-margin: 11px 36px 10px 4px !default;
21+
$radio-md-item-right-margin: $item-md-padding-media-top 10px $item-md-padding-media-bottom 0 !default;
2022

2123
ion-radio {
2224
position: relative;
@@ -97,7 +99,11 @@ ion-radio {
9799
position: static;
98100
display: block;
99101

100-
margin: $item-md-padding-media-top ($item-md-padding-right / 2) $item-md-padding-media-bottom 0;
102+
margin: $radio-md-item-right-margin;
103+
104+
&[item-left] {
105+
margin: $radio-md-item-left-margin;
106+
}
101107
}
102108

103109
.item-radio ion-label {

ionic/components/radio/radio.wp.scss

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,9 @@ $radio-wp-icon-border-radius: 50% !default;
1717

1818
$radio-wp-disabled-opacity: .3 !default;
1919

20+
$radio-wp-item-left-margin: 9px 20px 9px 4px !default;
21+
$radio-wp-item-right-margin: 11px 10px 10px 0 !default;
22+
2023

2124
ion-radio {
2225
position: relative;
@@ -99,7 +102,12 @@ ion-radio {
99102

100103
order: $radio-wp-order;
101104

102-
margin: $item-wp-padding-media-top $item-wp-padding-right $item-wp-padding-media-bottom 0;
105+
margin: $radio-wp-item-left-margin;
106+
107+
&[item-right] {
108+
order: 0;
109+
margin: $radio-wp-item-right-margin;
110+
}
103111
}
104112

105113
.item-radio ion-label {

ionic/components/radio/test/basic/main.html

Lines changed: 16 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,9 +14,14 @@
1414
Fruits
1515
</ion-list-header>
1616

17+
<ion-item>
18+
Button w/ left side default icon, really long text that should ellipsis
19+
<ion-icon name="information-circle" item-left></ion-icon>
20+
</ion-item>
21+
1722
<ion-item>
1823
<ion-label>Apple</ion-label>
19-
<ion-radio value="apple"></ion-radio>
24+
<ion-radio item-left value="apple"></ion-radio>
2025
</ion-item>
2126

2227
<ion-item>
@@ -34,6 +39,16 @@
3439
<ion-radio value="disabled" disabled="true"></ion-radio>
3540
</ion-item>
3641

42+
<ion-item>
43+
<ion-label>Radio right side</ion-label>
44+
<ion-radio item-right checked></ion-radio>
45+
</ion-item>
46+
47+
<ion-item>
48+
Button w/ right side default icon, really long text that should ellipsis
49+
<ion-icon name="information-circle" item-right></ion-icon>
50+
</ion-item>
51+
3752
</ion-list>
3853

3954
</form>

0 commit comments

Comments
 (0)