Skip to content

Commit 6e34739

Browse files
committed
fix(modal): add class name to modal
fixes #7000
1 parent ae40edf commit 6e34739

File tree

2 files changed

+11
-10
lines changed

2 files changed

+11
-10
lines changed

src/components/modal/modal.ts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -194,7 +194,9 @@ export class ModalCmp {
194194
this._compiler.resolveComponent(componentType).then((componentFactory) => {
195195
let componentRef = this.viewport.createComponent(componentFactory, this.viewport.length, this.viewport.parentInjector);
196196
this._renderer.setElementClass(componentRef.location.nativeElement, 'show-page', true);
197-
this._renderer.setElementClass(componentRef.location.nativeElement, componentType.name, true);
197+
// auto-add page css className created from component JS class name
198+
let cssClassName = pascalCaseToDashCase(componentType.name);
199+
this._renderer.setElementClass(componentRef.location.nativeElement, cssClassName, true);
198200
this._viewCtrl.setInstance(componentRef.instance);
199201
this.enabled = true;
200202
done();

src/components/modal/test/basic/index.ts

Lines changed: 8 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
1-
import {Component} from '@angular/core';
2-
import {ionicBootstrap, Config, Platform} from '../../../../../src';
3-
import {Modal, ActionSheet, NavController, NavParams, PageTransition, TransitionOptions, ViewController} from '../../../../../src';
1+
import { Component } from '@angular/core';
2+
3+
import { ActionSheet, Config, ionicBootstrap, Modal, NavController, NavParams, PageTransition, Platform, TransitionOptions, ViewController } from '../../../../../src';
44

55
@Component({
66
templateUrl: 'main.html'
@@ -25,7 +25,7 @@ class E2EPage {
2525
console.log('android', platform.is('android'));
2626
console.log('windows phone', platform.is('windows'));
2727

28-
platform.ready().then((readySource) => {
28+
platform.ready().then((readySource: string) => {
2929
console.log('platform.ready, readySource:', readySource);
3030
});
3131

@@ -73,7 +73,6 @@ class E2EPage {
7373
presentNavigableModal(){
7474
let modal = Modal.create(NavigableModal);
7575
this.nav.present(modal);
76-
//this.nav.push(NavigableModal);
7776
}
7877
}
7978

@@ -90,8 +89,8 @@ class E2EPage {
9089
</ion-content>
9190
`
9291
})
93-
class NavigableModal{
94-
constructor(private navController:NavController){
92+
class NavigableModal {
93+
constructor(private navController:NavController) {
9594
}
9695

9796
submit(){
@@ -112,8 +111,8 @@ class NavigableModal{
112111
</ion-content>
113112
`
114113
})
115-
class NavigableModal2{
116-
constructor(private navController:NavController){
114+
class NavigableModal2 {
115+
constructor(private navController:NavController) {
117116
}
118117

119118
submit(){

0 commit comments

Comments
 (0)