Skip to content
Permalink
Browse files

fix(angular): ensure all NavigationExtras values are preserved when n…

…avigating (#18468)

fixes #18469
  • Loading branch information...
MarkChrisLevy authored and liamdebeasi committed Jun 10, 2019
1 parent 54bdb36 commit 7610787e099f33d400c2abe32e3e61d87ff2ae2b
Showing with 6 additions and 1 deletion.
  1. +6 −1 angular/src/providers/nav-controller.ts
@@ -202,7 +202,12 @@ export class NavController {
urlTree.fragment = options.fragment;
}

return this.router!.navigateByUrl(urlTree);
/**
* `navigateByUrl` will still apply `NavigationExtras` properties
* that do not modify the url, such as `replaceUrl` which is why
* `options` is passed in here.
*/
return this.router!.navigateByUrl(urlTree, options);
}
}
}

0 comments on commit 7610787

Please sign in to comment.
You can’t perform that action at this time.