Skip to content

Commit 89ba55d

Browse files
committed
fix(overlay): overlay is not hidden
1 parent 2268346 commit 89ba55d

File tree

2 files changed

+3
-5
lines changed

2 files changed

+3
-5
lines changed

core/src/components/datetime/datetime.tsx

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -232,9 +232,7 @@ export class Datetime {
232232
const pickerOptions = this.generatePickerOptions();
233233
this.picker = await this.pickerCtrl.create(pickerOptions);
234234
await this.validate();
235-
if (this.picker) {
236-
await this.picker.present();
237-
}
235+
await this.picker.present();
238236
}
239237

240238
private emitStyle() {

core/src/utils/overlays.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ export function createOverlay<T extends HTMLIonOverlayElement>(element: T, opts:
99
// convert the passed in overlay options into props
1010
// that get passed down into the new overlay
1111
Object.assign(element, opts);
12-
element.classList.add('ion-page-hidden');
12+
element.classList.add('ion-page-invisible');
1313
const overlayIndex = lastId++;
1414
element.overlayIndex = overlayIndex;
1515
if (!element.hasAttribute('id')) {
@@ -137,7 +137,7 @@ async function overlayAnimation(
137137
}
138138

139139
// Make overlay visible in case it's hidden
140-
baseEl.classList.remove('ion-page-hidden');
140+
baseEl.classList.remove('ion-page-invisible');
141141

142142
const aniRoot = baseEl.shadowRoot || overlay.el;
143143
const animation = overlay.animation = await overlay.animationCtrl.create(animationBuilder, aniRoot, opts);

0 commit comments

Comments
 (0)