Skip to content

Commit 947780e

Browse files
committed
feat(virtual-scroll): apply contain:strict to virtual scroll items
1 parent a8002ce commit 947780e

File tree

3 files changed

+6
-14
lines changed

3 files changed

+6
-14
lines changed

src/components/virtual-scroll/test/list/app-module.ts

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -6,18 +6,17 @@ import { IonicApp, IonicModule } from '../../../..';
66
templateUrl: 'main.html'
77
})
88
export class E2EPage {
9-
items: Array<{title: string, date: string}>;
9+
items: Array<{title: string}>;
1010

1111
constructor() {
1212
this.emptyList();
1313
}
1414

1515
fillList() {
1616
this.items = [];
17-
for (let i = 0; i < 59; i++) {
17+
for (let i = 0; i < 500; i++) {
1818
this.items.push({
19-
title: 'Item ' + i,
20-
date: '23:' + (59 - i)
19+
title: 'Item ' + i
2120
});
2221
}
2322
}

src/components/virtual-scroll/test/list/main.html

Lines changed: 1 addition & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -20,16 +20,7 @@
2020
<ion-list [virtualScroll]="items">
2121

2222
<ion-item text-wrap *virtualItem="let item" (click)="itemTapped($event, item)">
23-
24-
<ion-row class="item-row">
25-
<ion-col class="item-title" width-80>
26-
{{item.title}}
27-
</ion-col>
28-
<ion-col class="item-time" width-20>
29-
{{item.date}}
30-
</ion-col>
31-
</ion-row>
32-
23+
{{item.title}}
3324
</ion-item>
3425

3526
</ion-list>

src/components/virtual-scroll/virtual-scroll.scss

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,8 @@
1414
left: 0;
1515

1616
transition-duration: 0ms;
17+
18+
contain: strict;
1719
}
1820

1921
.virtual-scroll .virtual-hidden {

0 commit comments

Comments
 (0)