fix(overlay): ensure lifecycles fire properly (#19579)

Author: liamdebeasi

core/src/components/modal/test/test.utils.ts

@@ -14,8 +14,16 @@ export const testModal = async (
   });
 
   const screenshotCompares = [];
+  const ionModalWillPresent = await page.spyOnEvent('ionModalWillPresent');
+  const ionModalDidPresent = await page.spyOnEvent('ionModalDidPresent');
+  const ionModalWillDismiss = await page.spyOnEvent('ionModalWillDismiss');
+  const ionModalDidDismiss = await page.spyOnEvent('ionModalDidDismiss');
 
   await page.click(selector);
+
+  await ionModalWillPresent.next();
+  await ionModalDidPresent.next();
+
   await page.waitForSelector(selector);
 
   let modal = await page.find('ion-modal');
@@ -25,6 +33,10 @@ export const testModal = async (
   screenshotCompares.push(await page.compareScreenshot());
 
   await modal.callMethod('dismiss');
+
+  await ionModalWillDismiss.next();
+  await ionModalDidDismiss.next();
+
   await modal.waitForNotVisible();
 
   screenshotCompares.push(await page.compareScreenshot('dismiss'));

core/src/utils/overlays.ts

@@ -221,7 +221,7 @@ const overlayAnimation = async (
   /**
    * TODO: Remove AnimationBuilder
    */
-  const hasCompleted = (typeof animationResult as any === 'boolean') ? animationResult : (animation as any).hasCompleted;
+  const hasCompleted = (typeof animationResult as any === 'undefined') ? true : (animation as any).hasCompleted;
   if (isAnimationBuilder) {
     animation.destroy();
   }