Skip to content

Commit bd96491

Browse files
fix(reorder-group): remove required parameter for the complete method (#18084)
also updates documentation surrounding the reorder & infinite scroll fixes #16302
1 parent a5b9066 commit bd96491

File tree

50 files changed

+1576
-551
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

50 files changed

+1576
-551
lines changed

core/src/components.d.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3520,7 +3520,7 @@ export namespace Components {
35203520

35213521
interface IonReorderGroup {
35223522
/**
3523-
* This method must be called once the `ionItemReorder` event is handled in order to complete the reorder operation.
3523+
* Completes the reorder operation. Must be called by the `ionItemReorder` event. If a list of items is passed, the list will be reordered and returned in the proper order. If no parameters are passed or if `true` is passed in, the reorder will complete and the item will remain in the position it was dragged to. If `false` is passed, the reorder will complete and the item will bounce back to its original position.
35243524
*/
35253525
'complete': (listOrReorder?: boolean | any[] | undefined) => Promise<any>;
35263526
/**

core/src/components/action-sheet/readme.md

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -186,7 +186,6 @@ export default class ActionSheetExample extends Component<Props, State> {
186186
);
187187
}
188188
}
189-
190189
```
191190

192191

core/src/components/action-sheet/usage/react.md

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,5 +59,4 @@ export default class ActionSheetExample extends Component<Props, State> {
5959
);
6060
}
6161
}
62-
6362
```

core/src/components/alert/readme.md

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -797,7 +797,6 @@ export default class AlertExample extends Component<Props, State> {
797797
);
798798
}
799799
}
800-
801800
```
802801

803802

core/src/components/alert/usage/react.md

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -267,5 +267,4 @@ export default class AlertExample extends Component<Props, State> {
267267
);
268268
}
269269
}
270-
271270
```

core/src/components/backdrop/readme.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -135,7 +135,7 @@ export default Example;
135135
import { Component, Vue } from 'vue-property-decorator';
136136
137137
@Component()
138-
export default class Menu extends Vue {
138+
export default class Example extends Vue {
139139
backdropDismiss = false;
140140
showBackdrop = false;
141141
shouldPropagate = false;

core/src/components/backdrop/usage/vue.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@
2424
import { Component, Vue } from 'vue-property-decorator';
2525
2626
@Component()
27-
export default class Menu extends Vue {
27+
export default class Example extends Vue {
2828
backdropDismiss = false;
2929
showBackdrop = false;
3030
shouldPropagate = false;

core/src/components/checkbox/readme.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -174,7 +174,7 @@ export default CheckboxExample;
174174
import { Component, Vue } from 'vue-property-decorator';
175175
176176
@Component()
177-
export default class Menu extends Vue {
177+
export default class Example extends Vue {
178178
form = [
179179
{ val: 'Pepperoni', isChecked: true },
180180
{ val: 'Sausage', isChecked: false },

core/src/components/checkbox/usage/vue.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@
2929
import { Component, Vue } from 'vue-property-decorator';
3030
3131
@Component()
32-
export default class Menu extends Vue {
32+
export default class Example extends Vue {
3333
form = [
3434
{ val: 'Pepperoni', isChecked: true },
3535
{ val: 'Sausage', isChecked: false },

core/src/components/datetime/readme.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -643,7 +643,7 @@ export default Example;
643643
import { Component, Vue } from 'vue-property-decorator';
644644
645645
@Component()
646-
export default class Menu extends Vue {
646+
export default class Example extends Vue {
647647
customYearValues = [2020, 2016, 2008, 2004, 2000, 1996];
648648
649649
customDayShortNames = [

0 commit comments

Comments
 (0)