Skip to content

Commit de0f9d5

Browse files
committed
fix(nav): make call to setPages return the promise so if it rejects it doesn't get lost
1 parent 4596dbe commit de0f9d5

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

src/components/nav/nav.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -114,7 +114,7 @@ export class Nav extends NavControllerBase implements AfterViewInit, RootNode, I
114114

115115
if (segment && (segment.component || segment.loadChildren)) {
116116
return this._linker.initViews(segment).then(views => {
117-
this.setPages(views, null, null);
117+
return this.setPages(views, null, null);
118118
});
119119
} else if (this._root) {
120120
// no segment match, so use the root property but don't set the url I guess
@@ -133,6 +133,7 @@ export class Nav extends NavControllerBase implements AfterViewInit, RootNode, I
133133
get root(): any {
134134
return this._root;
135135
}
136+
136137
set root(page: any) {
137138
this._root = page;
138139

0 commit comments

Comments
 (0)