Skip to content

Commit e3a8d27

Browse files
committed
fix(select): floating label
fixes #12068
1 parent d8b65da commit e3a8d27

File tree

3 files changed

+7
-5
lines changed

3 files changed

+7
-5
lines changed

src/components/item/test/inputs/pages/root-page/root-page.html

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -20,13 +20,14 @@
2020
</button>
2121

2222
<ion-item>
23-
<ion-label>DateTime</ion-label>
23+
<ion-label floating>DateTime</ion-label>
2424
<ion-datetime [(ngModel)]="datetime" min="1994-03-14" max="2017-12-09" displayFormat="MM/DD/YYYY" required [disabled]='disabled'></ion-datetime>
2525
</ion-item>
2626

2727
<ion-item>
28-
<ion-label>Select</ion-label>
28+
<ion-label floating>Select</ion-label>
2929
<ion-select [(ngModel)]="select" [disabled]='strDisabled()'>
30+
<ion-option value="">No Game Console</ion-option>
3031
<ion-option value="nes">NES</ion-option>
3132
<ion-option value="n64">Nintendo64</ion-option>
3233
<ion-option value="ps">PlayStation</ion-option>
@@ -42,7 +43,7 @@
4243
</ion-item>
4344

4445
<ion-item>
45-
<ion-label>Input (text)</ion-label>
46+
<ion-label floating>Input (text)</ion-label>
4647
<ion-input [(ngModel)]="text" [disabled]='disabled'></ion-input>
4748
</ion-item>
4849

src/components/select/select.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -496,6 +496,7 @@ export class Select extends BaseInput<any> implements OnDestroy {
496496
}
497497

498498
this._text = this._texts.join(', ');
499+
super._inputUpdated();
499500
}
500501

501502
}

src/components/select/test/single-value/pages/page-one/page-one.html

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
<ion-content class="outer-content">
1111

1212
<ion-item>
13-
<ion-label>Gender</ion-label>
13+
<ion-label stacked>Gender</ion-label>
1414
<ion-select [(ngModel)]="gender" class="e2eSelectGender">
1515
<ion-option value="f">Female</ion-option>
1616
<ion-option value="m">Male</ion-option>
@@ -39,7 +39,7 @@
3939
</ion-item>
4040

4141
<ion-item>
42-
<ion-label>Operating System</ion-label>
42+
<ion-label floating>Operating System</ion-label>
4343
<ion-select [(ngModel)]="os" interface="alert" submitText="Okay" cancelText="Nah">
4444
<ion-option value="dos">DOS</ion-option>
4545
<ion-option value="lunix">Linux</ion-option>

0 commit comments

Comments
 (0)