Skip to content

Commit e3d7282

Browse files
fix(action-sheet): set 100% height to fix scrollable options (#16789)
* test(action-sheet): include more buttons to scroll in the screenshot
1 parent c9cef12 commit e3d7282

File tree

2 files changed

+18
-2
lines changed

2 files changed

+18
-2
lines changed

core/src/components/action-sheet/action-sheet.scss

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,8 +23,8 @@
2323
--width: #{$action-sheet-width};
2424
--max-width: #{$action-sheet-max-width};
2525
--min-height: auto;
26-
--height: auto;
27-
--max-height: auto;
26+
--height: 100%;
27+
--max-height: 100%;
2828

2929
@include font-smoothing();
3030
@include position(0, 0, 0, 0);

core/src/components/action-sheet/test/scrollable-options/index.html

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -73,11 +73,21 @@
7373
handler: () => {
7474
console.log('Mark Unread clicked');
7575
}
76+
}, {
77+
text: 'Mark Read',
78+
handler: () => {
79+
console.log('Mark Read clicked');
80+
}
7681
}, {
7782
text: 'Edit Title',
7883
handler: () => {
7984
console.log('Edit Title clicked');
8085
}
86+
}, {
87+
text: 'Erase Title',
88+
handler: () => {
89+
console.log('Erase Title clicked');
90+
}
8191
}, {
8292
text: 'Save Image',
8393
handler: () => {
@@ -88,6 +98,12 @@
8898
handler: () => {
8999
console.log('Copy Image clicked');
90100
}
101+
}, {
102+
}, {
103+
text: 'Erase Image',
104+
handler: () => {
105+
console.log('Erase Image clicked');
106+
}
91107
}, {
92108
text: 'Delete File',
93109
role: 'destructive',

0 commit comments

Comments
 (0)