Skip to content

Commit e423e08

Browse files
soumak77jgw96
authored andcommitted
fix(tabs): invalid component comparison (#11084)
getComponent() returns a ViewController, so we must reference the component property when checking against the active component
1 parent 786de79 commit e423e08

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

src/components/tabs/tabs.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -511,7 +511,7 @@ export class Tabs extends Ion implements AfterViewInit, RootNode {
511511
});
512512
} else {
513513
getComponent(this._linker, tab.root).then(viewController => {
514-
if (viewController !== active.component) {
514+
if (viewController.component !== active.component) {
515515
// Otherwise, if the page we're on is not our real root
516516
// reset it to our default root type
517517
return tab.setRoot(tab.root);

0 commit comments

Comments
 (0)