Skip to content

Commit f13722c

Browse files
masimploliamdebeasi
authored andcommitted
fix(item-sliding): hide opposite side options when other side is open (#17986)
* fix(item-sliding): hide opposite side options * Fix padding issue * add visibility hidden for item options
1 parent 983382c commit f13722c

File tree

3 files changed

+42
-2
lines changed

3 files changed

+42
-2
lines changed

core/src/components/item-options/item-options.scss

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -77,6 +77,8 @@ ion-item-options {
7777

7878
ion-item-options {
7979
display: flex;
80+
81+
visibility: hidden;
8082
}
8183

8284
&.item-sliding-active-options-start .item-options-start,

core/src/components/item-sliding/item-sliding.scss

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ ion-item-sliding .item {
3333
.item-sliding-active-swipe-end .item-options-end .item-option-expandable {
3434
@include multi-dir() {
3535
/* stylelint-disable-next-line property-blacklist */
36-
padding-left: 90%;
36+
padding-left: 100%;
3737
}
3838

3939
@include ltr() {
@@ -51,7 +51,7 @@ ion-item-sliding .item {
5151
.item-sliding-active-swipe-start .item-options-start .item-option-expandable {
5252
@include multi-dir() {
5353
/* stylelint-disable-next-line property-blacklist */
54-
padding-right: 90%;
54+
padding-right: 100%;
5555
}
5656

5757
@include ltr() {

core/src/components/item-sliding/test/basic/index.html

Lines changed: 38 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -310,6 +310,44 @@ <h2>ion-item-sliding without options (no sliding)</h2>
310310
</ion-item>
311311
</ion-item-sliding>
312312

313+
<ion-item-sliding id="item10">
314+
<ion-item detail>
315+
<ion-label text-wrap>
316+
<h2>RIGHT/LEFT side - many buttons</h2>
317+
<p>Use mobile emulator to check</p>
318+
</ion-label>
319+
</ion-item>
320+
<ion-item-options side="start" class="sliding-enabled">
321+
<ion-item-option color="primary" expandable>
322+
<ion-icon name="ios-checkmark"></ion-icon>Btn 1
323+
</ion-item-option>
324+
<ion-item-option color="secondary" expandable>
325+
<ion-icon name="ios-checkmark"></ion-icon>Btn 2
326+
</ion-item-option>
327+
<ion-item-option color="danger" expandable>
328+
<ion-icon name="ios-checkmark"></ion-icon>Btn 3
329+
</ion-item-option>
330+
<ion-item-option color="tertiary" expandable>
331+
<ion-icon name="ios-checkmark"></ion-icon>Btn 4
332+
</ion-item-option>
333+
</ion-item-options>
334+
335+
<ion-item-options side="end" class="sliding-enabled">
336+
<ion-item-option color="primary" expandable>
337+
<ion-icon name="mail"></ion-icon>Btn 5
338+
</ion-item-option>
339+
<ion-item-option color="secondary" expandable>
340+
<ion-icon name="mail"></ion-icon>Btn 6
341+
</ion-item-option>
342+
<ion-item-option color="danger" expandable>
343+
<ion-icon name="mail"></ion-icon>Btn 7
344+
</ion-item-option>
345+
<ion-item-option color="tertiary" expandable>
346+
<ion-icon name="mail"></ion-icon>Btn 8
347+
</ion-item-option>
348+
</ion-item-options>
349+
</ion-item-sliding>
350+
313351
<ion-item>
314352
<ion-label text-wrap>
315353
<h2>Normal ion-item (no sliding)</h2>

0 commit comments

Comments
 (0)