Skip to content

Commit f355087

Browse files
committed
fix(slides): make slide method parameters optional
references #5508
1 parent ab82d53 commit f355087

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

ionic/components/slides/slides.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -787,7 +787,7 @@ export class Slides extends Ion {
787787
* @param {number} speed Transition duration (in ms). Optional.
788788
* @param {boolean} runCallbacks Whether or not to emit the `willChange`/`didChange` events. Optional. Default true.
789789
*/
790-
slideTo(index: number, speed: number, runCallbacks: boolean) {
790+
slideTo(index: number, speed?: number, runCallbacks?: boolean) {
791791
this.slider.slideTo(index, speed, runCallbacks);
792792
}
793793

@@ -797,7 +797,7 @@ export class Slides extends Ion {
797797
* @param {number} speed Transition duration (in ms). Optional.
798798
* @param {boolean} runCallbacks Whether or not to emit the `willChange`/`didChange` events. Optional. Default true.
799799
*/
800-
slideNext(speed: number, runCallbacks: boolean) {
800+
slideNext(speed?: number, runCallbacks?: boolean) {
801801
this.slider.slideNext(runCallbacks, speed);
802802
}
803803

@@ -807,7 +807,7 @@ export class Slides extends Ion {
807807
* @param {number} speed Transition duration (in ms). Optional.
808808
* @param {boolean} runCallbacks Whether or not to emit the `willChange`/`didChange` events. Optional. Default true.
809809
*/
810-
slidePrev(speed: number, runCallbacks: boolean) {
810+
slidePrev(speed?: number, runCallbacks?: boolean) {
811811
this.slider.slidePrev(runCallbacks, speed);
812812
}
813813

ionic/components/slides/test/controller/index.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,5 +49,5 @@ class MyPage {
4949
template: `<ion-nav [root]="root"></ion-nav>`
5050
})
5151
class E2EApp {
52-
root: Page = MyPage;
52+
root: any = MyPage;
5353
}

0 commit comments

Comments
 (0)