Skip to content

Conversation

liamdebeasi
Copy link
Contributor

@liamdebeasi liamdebeasi commented Nov 21, 2019

⚠️ Add Manu as co-author when merging

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

progressEnd web animations were not being updated properly

What is the new behavior?

  1. Ensure progressEnd updates Web Animations
  2. Update types.
  3. Reorganize code a bit

Does this introduce a breaking change?

  • Yes
  • No

Other information

@ionitron-bot ionitron-bot bot added the package: core @ionic/core package label Nov 21, 2019
@liamdebeasi liamdebeasi marked this pull request as ready for review November 21, 2019 15:35
@liamdebeasi liamdebeasi merged commit e766194 into master Nov 21, 2019
@liamdebeasi liamdebeasi deleted the animation-interface-updates branch November 21, 2019 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: core @ionic/core package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant