-
Notifications
You must be signed in to change notification settings - Fork 13.4k
feat(back-button): add 'backButtonDefaultHref' property to IonicConfig #20491
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thank you for the PR! We've discussed this and will be adding it, but at the moment we're focused on getting some fixes in so this will have to be open for a bit until we decide to do a feature release. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Can we just fix that merge conflict?
I pushed some fixes for this so it would work with Angular. The
|
This is ready to merge now! Thanks for working on this. 🙂 |
Pull request checklist
Please check if your PR fulfills the following requirements:
npm run build
) was run locally and any changes were pushednpm run lint
) has passed locally and any fixes were made for failuresPull request type
Please check the type of change your PR introduces:
What is the current behavior?
Issue Number: #19305
What is the new behavior?
Does this introduce a breaking change?
Other information